Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update override files for ephemeral volumes perf test cases #653

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Update override files for ephemeral volumes perf test cases #653

merged 1 commit into from
Jul 18, 2019

Conversation

mucahitkurt
Copy link
Contributor

Different override files are added for the max volumes per pod test case and emptydir volume type to make tests explicit.

Related comment: kubernetes/test-infra#13471 (comment)
Related issue: #600
Related PR: #601

/assign @wojtek-t
/sig storage
/sig scalability
/kind cleanup

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 17, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @mucahitkurt. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 17, 2019
@k8s-ci-robot k8s-ci-robot requested review from krzysied and mm4tt July 17, 2019 19:50
@mucahitkurt mucahitkurt mentioned this pull request Jul 17, 2019
Merged
wojtek-t
wojtek-t reviewed Jul 18, 2019
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - just one minor nit.

clusterloader2/testing/experimental/storage/pod-startup/ephemeral-volumes/1_node/README.md Outdated
@@ -7,4 +7,4 @@ Below test cases can be run with the parameters like;

To test with different volume types please use the override file for the specific volume type, default volume type is `EmptyDir`

To test for the max volume per node test case please use override file under `max_volumes_per_node`, default test case is max volume per node.
There two different test cases and different override files for each of them, `max_volumes_per_pod` and `max_volumes_per_node`, default test case is max volume per pod.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/There/There are/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks!

@wojtek-t
Copy link
Member

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2019
@mucahitkurt mucahitkurt force-pushed the storage/overrides-for-emptydir-and-maxvolperpod-testcases branch from 33c3433 to 99f93d8 Compare July 18, 2019 17:21
@wojtek-t
Copy link
Member

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mucahitkurt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a743784 into kubernetes:master Jul 18, 2019
@mucahitkurt mucahitkurt mentioned this pull request Sep 7, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@krzysied krzysied Awaiting requested review from krzysied

@mm4tt mm4tt Awaiting requested review from mm4tt

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mucahitkurt @k8s-ci-robot @wojtek-t