Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jq to format Grafana dashboards in json files #558

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

oxddr
Copy link
Contributor

@oxddr oxddr commented Jun 5, 2019

Also add make target to simplify usage for other contributors.

/kind cleanup
/assign @mm4tt

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 5, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @oxddr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 5, 2019
@k8s-ci-robot k8s-ci-robot requested review from mborsz and mm4tt June 5, 2019 11:43
@mborsz
Copy link
Member

mborsz commented Jun 5, 2019

Nice, thanks
/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 5, 2019
@mm4tt
Copy link
Contributor

mm4tt commented Jun 5, 2019

Nice, can we have it in the verify/ dir (and in the verify + print command how to fix form) and run it as a part of presubmit?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2019
@oxddr
Copy link
Contributor Author

oxddr commented Jun 5, 2019

Nice, can we have it in the verify/ dir (and in the verify + print command how to fix form) and run it as a part of presubmit?

Done. I am not sure whether travis config is 100% correct.

@mm4tt
Copy link
Contributor

mm4tt commented Jun 6, 2019

Nice, thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 6, 2019
@mm4tt
Copy link
Contributor

mm4tt commented Jun 6, 2019

Oh, looks like there are merge conflicts, please fix

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2019
Check for formatting problems at presubmit.
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 7, 2019
@oxddr
Copy link
Contributor Author

oxddr commented Jun 7, 2019

@mm4tt PTAL

@mm4tt
Copy link
Contributor

mm4tt commented Jun 7, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, mm4tt, oxddr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0fe7891 into kubernetes:master Jun 7, 2019
@oxddr oxddr deleted the format branch July 5, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants