-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jq to format Grafana dashboards in json files #558
Conversation
Hi @oxddr. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Nice, thanks |
Nice, can we have it in the verify/ dir (and in the verify + print command how to fix form) and run it as a part of presubmit? |
Done. I am not sure whether travis config is 100% correct. |
Nice, thanks! |
Oh, looks like there are merge conflicts, please fix |
Check for formatting problems at presubmit.
@mm4tt PTAL |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mborsz, mm4tt, oxddr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also add make target to simplify usage for other contributors.
/kind cleanup
/assign @mm4tt