Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recording rule for Network Programming Latency #557

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Recording rule for Network Programming Latency #557

merged 2 commits into from
Jun 19, 2019

Conversation

oxddr
Copy link
Contributor

@oxddr oxddr commented Jun 4, 2019 •
edited
Loading

This is based on work by @mm4tt in #430.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @oxddr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 4, 2019
@k8s-ci-robot k8s-ci-robot requested review from krzysied and wojtek-t June 4, 2019 15:52
@oxddr oxddr force-pushed the kube-proxy-scrapping branch from 6d0badc to ba7c9ea Compare June 5, 2019 09:53
@oxddr
Copy link
Contributor Author

oxddr commented Jun 5, 2019

/assign @mm4tt

@mm4tt
Copy link
Contributor

mm4tt commented Jun 5, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 5, 2019
@mm4tt
Copy link
Contributor

mm4tt commented Jun 5, 2019

You'll also need a kube-proxy service that was temporarily removed in #528

https://github.com/kubernetes/perf-tests/blob/d2d330760c0061bd80d3987a03e5c5f34025f727/clusterloader2/pkg/prometheus/manifests/default/kube-proxy-service.yaml

@oxddr oxddr force-pushed the kube-proxy-scrapping branch from ba7c9ea to 6af3b98 Compare June 5, 2019 16:48
@oxddr
Copy link
Contributor Author

oxddr commented Jun 5, 2019

/retest

@oxddr oxddr mentioned this pull request Jun 6, 2019
Closed
6 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2019
@mm4tt @oxddr
Recording rule for Network Programming Latency.
27b0c54 
This rule will be used in the Network Programming Latency dashboard.
It's recommended by Prometheus documentation to use recording rules for
dashboards, see https://prometheus.io/docs/prometheus/latest/configuration/recording_rules/

I also modified the kube-proxy scrape interval, as now thanks to the
recording rule we should be able to scrape more often.
@oxddr oxddr force-pushed the kube-proxy-scrapping branch from 45b10d4 to 2a4f136 Compare June 10, 2019 12:55
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 10, 2019
@oxddr oxddr force-pushed the kube-proxy-scrapping branch from 2a4f136 to ad6174f Compare June 10, 2019 12:56
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 10, 2019
@oxddr oxddr force-pushed the kube-proxy-scrapping branch from ad6174f to 6143c02 Compare June 10, 2019 12:57
@oxddr
Copy link
Contributor Author

oxddr commented Jun 12, 2019

@mm4tt PTAL

mm4tt
mm4tt requested changes Jun 13, 2019
View reviewed changes
clusterloader2/pkg/prometheus/experimental.go Outdated Show resolved Hide resolved
clusterloader2/pkg/prometheus/experimental.go Outdated Show resolved Hide resolved
clusterloader2/pkg/prometheus/experimental.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 13, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 13, 2019
@oxddr oxddr force-pushed the kube-proxy-scrapping branch from 14b4b63 to e94a625 Compare June 13, 2019 15:22
@oxddr
Add headless service so kube-proxy can be scraped.
1ebb44f 
1. Fix incorrect metrics names and use record rule in dashboard.
2. Use environmental variables to gate kube-proxy scrapping.
3. Change framework so it ignores empty manifests
@oxddr oxddr force-pushed the kube-proxy-scrapping branch from e94a625 to 1ebb44f Compare June 18, 2019 15:51
@oxddr
Copy link
Contributor Author

oxddr commented Jun 18, 2019

PTAL

@mm4tt
Copy link
Contributor

mm4tt commented Jun 19, 2019

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mm4tt, oxddr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 02812f3 into kubernetes:master Jun 19, 2019
@oxddr oxddr deleted the kube-proxy-scrapping branch July 5, 2019 08:42
@mm4tt mm4tt mentioned this pull request Jul 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm4tt mm4tt mm4tt requested changes

@krzysied krzysied Awaiting requested review from krzysied

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@mm4tt mm4tt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oxddr @k8s-ci-robot @mm4tt