Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable govet in golangci-lint #1448

Merged
merged 1 commit into from
Sep 1, 2020
Merged

feat: enable govet in golangci-lint #1448

merged 1 commit into from
Sep 1, 2020

Conversation

kushthedude
Copy link
Contributor

Signed-off-by: Kush Trivedi [email protected]

Refers #1244

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 1, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @kushthedude. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 1, 2020
@kushthedude kushthedude mentioned this pull request Sep 1, 2020
Open
@kushthedude
Copy link
Contributor Author

/assign @timothysc
/cc @wojtek-t

@wojtek-t
Copy link
Member

wojtek-t commented Sep 1, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 1, 2020
@wojtek-t
Copy link
Member

wojtek-t commented Sep 1, 2020

@kushthedude - seems there are number of issues that has to be fixed before enabling them

@kushthedude
Copy link
Contributor Author

@kushthedude - seems there are number of issues that has to be fixed before enabling them

Yes, strange that most of these issues were not reported by govet on local.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 1, 2020
@kushthedude
Copy link
Contributor Author

@wojtek-t Commenting out misspell right now as most of the spell errors are in the vendor modules which should not be fixed by us. This should be enabled when we have migrated completely to go modules.

wojtek-t
wojtek-t reviewed Sep 1, 2020
View reviewed changes
.golangci.yml Outdated Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
@kushthedude kushthedude force-pushed the vet branch 2 times, most recently from 0b5cede to 7a50eab Compare September 1, 2020 10:08
@kushthedude kushthedude changed the title feat: enable govet & misspell in golangci-lint feat: enable govet in golangci-lint Sep 1, 2020
@kushthedude kushthedude requested a review from wojtek-t September 1, 2020 10:30
wojtek-t
wojtek-t reviewed Sep 1, 2020
View reviewed changes
.golangci.yml
- (github.com/golangci/golangci-lint/pkg/logutils.Log).Warnf
- (github.com/golangci/golangci-lint/pkg/logutils.Log).Errorf
- (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf
disable:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a TODO to get rid of those disabled ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@kushthedude kushthedude requested a review from wojtek-t September 1, 2020 11:21
@wojtek-t
Copy link
Member

wojtek-t commented Sep 1, 2020

Something doesn't work now - please fix

@kushthedude
Copy link
Contributor Author

kushthedude commented Sep 1, 2020 •
edited
Loading

Something doesn't work now - please fix

Was an error in linting the configuration file, fixed now!

Edit: Working now @wojtek-t !

@wojtek-t
Copy link
Member

wojtek-t commented Sep 1, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kushthedude, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit cf32603 into kubernetes:master Sep 1, 2020
@kushthedude kushthedude deleted the vet branch September 1, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarek gmarek Awaiting requested review from gmarek

@timothysc timothysc Awaiting requested review from timothysc

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@timothysc timothysc

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kushthedude @k8s-ci-robot @wojtek-t @timothysc