feat: add deadcode linter in golangci-lint

Signed-off-by: Kush Trivedi <[email protected]>
kubernetes · Sep 1, 2020 · a073729 · a073729
1 parent dc53daa
commit a073729
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 20 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -13,8 +13,8 @@ linters:
     - gofmt
     - golint
     - errcheck
+    - deadcode
     # TODO(oxddr): enable more checkers
-    # - deadcode
     # - misspell
 
 service:

diff --git a/compare/src/compare-resources.go b/compare/src/compare-resources.go
@@ -136,13 +136,6 @@ func max(left, right int64) int64 {
 	return right
 }
 
-func min(left, right int64) int64 {
-	if left < right {
-		return left
-	}
-	return right
-}
-
 func getContainerKind(containerName string) string {
 	return containerName[strings.LastIndex(containerName, "/")+1:]
 }

diff --git a/network/benchmarks/netperf/launch.go b/network/benchmarks/netperf/launch.go
@@ -41,7 +41,6 @@ import (
 )
 
 const (
-	debugLog         = "output.txt"
 	testNamespace    = "netperf"
 	csvDataMarker    = "GENERATING CSV OUTPUT"
 	csvEndDataMarker = "END CSV DATA"

diff --git a/perfdash/config.go b/perfdash/config.go
@@ -52,9 +52,6 @@ type Tests struct {
 // Jobs is a map from job name to all supported tests in the job.
 type Jobs map[string]Tests
 
-// Buckets is a map from bucket url to all supported jobs in the bucket.
-type Buckets map[string]Jobs
-
 var (
 	// performanceDescriptions contains metrics exported by a --ginko.focus=[Feature:Performance]
 	// e2e test
@@ -367,14 +364,6 @@ var (
 	}
 )
 
-func getProwConfigOrDie(configPaths []string) Jobs {
-	jobs, err := getProwConfig(configPaths)
-	if err != nil {
-		panic(err)
-	}
-	return jobs
-}
-
 // Minimal subset of the prow config definition at k8s.io/test-infra/prow/config
 type config struct {
 	Periodics []periodic `json:"periodics"`