Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add teams for apiserver-network-proxy #724

Merged
merged 3 commits into from
Apr 16, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Apr 16, 2019

Ref: #715

@cheftako and @anfernee are members of Kubernetes but were not members of Kubernetes SIGs so I've added them as members in this PR (members of Kubernetes are implicitly eligible for membership to Kubernetes SIGs).

/assign @cheftako @andrewsykim

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2019
@andrewsykim
Copy link
Member

/lgtm

Thank you @nikhita!!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2d4183e into kubernetes:master Apr 16, 2019
@nikhita nikhita deleted the apiserver-network-proxy branch April 16, 2019 15:46
@anfernee
Copy link
Member

Thank you @nikhita

1 similar comment
@cheftako
Copy link
Member

Thank you @nikhita

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants