Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add members 2019-03-17 #620

Merged
merged 3 commits into from
Mar 18, 2019
Merged

Add members 2019-03-17 #620

merged 3 commits into from
Mar 18, 2019

Conversation

mrbobbytables
Copy link
Member

fixes #611
fixes #613
fixes #619

/area github-membership

@k8s-ci-robot k8s-ci-robot added area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2019
This was referenced Mar 18, 2019
Closed
Closed
Closed
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2019
nikhita
nikhita approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, mrbobbytables, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2019
@nikhita
Copy link
Member

nikhita commented Mar 18, 2019

In the mood for a joke this morning...

/joke

@k8s-ci-robot
Copy link
Contributor

@nikhita: I have kleptomania, but when it gets bad, I take something for it.

In response to this:

In the mood for a joke this morning...

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 787eb72 into kubernetes:master Mar 18, 2019
@juan-lee
Copy link

@mrbobbytables @justaugustus @nikhita Oddly I don't seem to appear in the kubernetes or kubernetes-sigs orgs. Perhaps it has something to do with the hyphen in my username. Any ideas?

@mrbobbytables
Copy link
Member Author

@juan-lee Can you try going here:
https://github.com/orgs/kubernetes/invitation
https://github.com/orgs/kubernetes-sigs/invitation

The links should have been sent to you in your email from github, but to be added as a member you must first accept the org invitation.

@juan-lee
Copy link

ha! rtfm

thanks @mrbobbytables

@mrbobbytables mrbobbytables deleted the add-members-2019-03-17 branch April 2, 2019 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@justaugustus justaugustus

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
5 participants
@mrbobbytables @justaugustus @k8s-ci-robot @nikhita @juan-lee