Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.26 RT Shadows #3686

Merged
merged 5 commits into from
Sep 21, 2022
Merged

Conversation

leonardpahlke
Copy link
Member

Signed-off-by: leonardpahlke [email protected]

Add 1.26 RT Shadows

cc @kubernetes/release-team-leads @palnabarun

Signed-off-by: leonardpahlke <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Sep 13, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2022
Signed-off-by: leonardpahlke <[email protected]>
config/kubernetes/sig-release/teams.yaml Outdated Show resolved Hide resolved
config/kubernetes/sig-release/teams.yaml Outdated Show resolved Hide resolved
config/kubernetes/sig-release/teams.yaml Outdated Show resolved Hide resolved
Signed-off-by: leonardpahlke <[email protected]>
@palnabarun
Copy link
Member

We have 3 shadows pending to be added to the org.

    config_test.go:272: The following members of team release-team are not Kubernetes org members: heshamaboelmagd, neoaggelos, subhasmitasw
    config_test.go:272: The team release-team in org Kubernetes has an unsorted list of members 

@palnabarun
Copy link
Member

Once #3708 merges, the remaining members would need to accept the org invitation request. And then this PR should be 🟢.

@reylejano
Copy link
Member

/test pull-org-test-all

Signed-off-by: leonardpahlke <[email protected]>
@leonardpahlke
Copy link
Member Author

Thanks, @palnabarun @reylejano and @fsmunoz for your reviews :) Now it looks like the PR is finally ready to get merged

@leonardpahlke
Copy link
Member Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 21, 2022
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leonardpahlke, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit dedc2fc into kubernetes:main Sep 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Sep 21, 2022
@leonardpahlke leonardpahlke deleted the update-1-26-rt-shadows branch September 21, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants