Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add members 2020-02-25 #3286

Merged
merged 5 commits into from
Feb 25, 2022
Merged

Conversation

palnabarun
Copy link
Member

@palnabarun palnabarun commented Feb 25, 2022

fixes #3255
fixes #3265
fixes #3275
fixes #3278
fixes #3280

Signed-off-by: Nabarun Pal [email protected]

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2022
@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label Feb 25, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2022
Signed-off-by: Nabarun Pal <[email protected]>
@palnabarun palnabarun mentioned this pull request Feb 25, 2022
9 tasks
@palnabarun palnabarun changed the title WIP: Add members 2020-02-25 Add members 2020-02-25 Feb 25, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2022
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/meow

@k8s-ci-robot
Copy link
Contributor

@nikhita: cat image

In response to this:

/lgtm
/approve

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xing-yang
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit ee94f6e into kubernetes:main Feb 25, 2022
@palnabarun palnabarun deleted the add-members/2022-02-25 branch February 28, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
4 participants