Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Members 2022-02-11 #3247

Merged
merged 11 commits into from
Feb 11, 2022
Merged

Conversation

palnabarun
Copy link
Member

@palnabarun palnabarun commented Feb 11, 2022

fixes #3191
fixes #3222
fixes #3225
fixes #3229
fixes #3232
fixes #3233
fixes #3239
fixes #3240
fixes #3244
fixes #3245
fixes #3246

/hold for all requests

Signed-off-by: Nabarun Pal [email protected]

Signed-off-by: Nabarun Pal <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/github-management Issues or PRs related to GitHub Management subproject labels Feb 11, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2022
@palnabarun palnabarun mentioned this pull request Feb 11, 2022
7 tasks
Signed-off-by: Nabarun Pal <[email protected]>
@palnabarun palnabarun force-pushed the add-members/2022-02-11 branch from 787e9e3 to 248294b Compare February 11, 2022 07:22
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2022
Signed-off-by: Nabarun Pal <[email protected]>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@palnabarun
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2022
@palnabarun
Copy link
Member Author

/cc @nikhita

@k8s-ci-robot k8s-ci-robot requested a review from nikhita February 11, 2022 07:28
@ameukam
Copy link
Member

ameukam commented Feb 11, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit b533ed8 into kubernetes:main Feb 11, 2022
@palnabarun
Copy link
Member Author

Thanks @ameukam !!

@palnabarun palnabarun deleted the add-members/2022-02-11 branch February 11, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
3 participants