Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Members 2021-01-07 #3167

Merged
merged 9 commits into from
Jan 7, 2022
Merged

Add Members 2021-01-07 #3167

merged 9 commits into from
Jan 7, 2022

Conversation

palnabarun
Copy link
Member

@palnabarun palnabarun commented Jan 7, 2022 •
edited
Loading

fixes #3145
fixes #3151
fixes #3152
fixes #3154
fixes #3156
fixes #3157
fixes #3159
fixes #3160
fixes #3162

/cc @nikhita

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/github-management Issues or PRs related to GitHub Management subproject labels Jan 7, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2022
@palnabarun palnabarun mentioned this pull request Jan 7, 2022
Closed
7 tasks
@palnabarun palnabarun mentioned this pull request Jan 7, 2022
Closed
7 tasks
@palnabarun palnabarun mentioned this pull request Jan 7, 2022
Closed
7 tasks
@palnabarun palnabarun mentioned this pull request Jan 7, 2022
Closed
7 tasks
@palnabarun palnabarun mentioned this pull request Jan 7, 2022
Closed
7 tasks
@palnabarun palnabarun mentioned this pull request Jan 7, 2022
Closed
7 tasks
@palnabarun palnabarun mentioned this pull request Jan 7, 2022
Closed
7 tasks
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 7, 2022
@palnabarun
add klaases to kubernetes
19adc9c 
Signed-off-by: Nabarun Pal <[email protected]>
@palnabarun palnabarun mentioned this pull request Jan 7, 2022
Closed
7 tasks
@palnabarun palnabarun mentioned this pull request Jan 7, 2022
Closed
7 tasks
@palnabarun
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2022
nikhita
nikhita approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/meow space

@k8s-ci-robot
Copy link
Contributor

@nikhita: cat image

In response to this:

/lgtm

/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8f7b5d5 into kubernetes:main Jan 7, 2022
@anubha-v-ardhan
Copy link
Member

/meow

@k8s-ci-robot
Copy link
Contributor

@anubha-v-ardhan: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@palnabarun palnabarun deleted the add-members-2021-01-07 branch January 8, 2022 15:39
@Anubhavdevv
Copy link

/meow

@k8s-ci-robot
Copy link
Contributor

@Anubhavdevv: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlsong01
Copy link

/meow

@k8s-ci-robot
Copy link
Contributor

@jlsong01: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita approved these changes

@fejta fejta Awaiting requested review from fejta

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
6 participants
@palnabarun @k8s-ci-robot @anubha-v-ardhan @Anubhavdevv @jlsong01 @nikhita