Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.21 Docs Shadows to GitHub teams #2445

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Add 1.21 Docs Shadows to GitHub teams #2445

merged 1 commit into from
Jan 20, 2021

Conversation

reylejano
Copy link
Member

@reylejano reylejano commented Jan 19, 2021

Add 1.21 Docs Shadows to website-milestone-maintainers in sig-docs/teams.yaml and release-team in sig-release/teams.yaml GitHub teams

/assign @palnabarun @kikisdeliveryservice @savitharaghunathan @bai

/hold for feedback if shadows should be added to the website-milestone-maintainers team.
I think they should have the ability to add the 1.21 milestone on kubernetes/website PRs.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 19, 2021
@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jan 19, 2021
config/kubernetes/sig-release/teams.yaml Outdated Show resolved Hide resolved
config/kubernetes/sig-release/teams.yaml Outdated Show resolved Hide resolved
@reylejano
Copy link
Member Author

/retest

1 similar comment
@reylejano
Copy link
Member Author

/retest

Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I agree with shadows having permissions to add/remove milestones.

@reylejano please make sure that the handbook reflects this and add a cleanup step for the same. Thank you.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2021
@reylejano
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2021
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if shadows should be added to the milestone maintainers team.

@reylejano -- I think access for adding/removing milestones on k/website is given through the website-milestone-maintainers group. Ref: https://github.com/kubernetes/org/blob/master/config/kubernetes/sig-docs/teams.yaml#L342

If the shadows don't need access to globally add/remove milestones, I think website-milestone-maintainers is the better place.

LMK what do you think.

/hold for resolution on the above

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2021
Add 1.21 Docs Shadows to GitHub teams

Add 1.21 Docs Shadows to GitHub teams
@reylejano
Copy link
Member Author

if shadows should be added to the milestone maintainers team.

@reylejano -- I think access for adding/removing milestones on k/website is given through the website-milestone-maintainers group. Ref: https://github.com/kubernetes/org/blob/master/config/kubernetes/sig-docs/teams.yaml#L342

If the shadows don't need access to globally add/remove milestones, I think website-milestone-maintainers is the better place.

LMK what do you think.

/hold for resolution on the above

@palnabarun I removed the shadows from the milestone-maintners and added them to website-milestone-maintainers in sig-docs/teams.yaml

@palnabarun
Copy link
Member

@reylejano -- Awesome! Thank you so much :)

/lgtm
/approve

@palnabarun
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: palnabarun, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 84412d0 into kubernetes:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants