-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1.21 Docs Shadows to GitHub teams #2445
Add 1.21 Docs Shadows to GitHub teams #2445
Conversation
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I agree with shadows having permissions to add/remove milestones.
@reylejano please make sure that the handbook reflects this and add a cleanup step for the same. Thank you.
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if shadows should be added to the milestone maintainers team.
@reylejano -- I think access for adding/removing milestones on k/website
is given through the website-milestone-maintainers
group. Ref: https://github.com/kubernetes/org/blob/master/config/kubernetes/sig-docs/teams.yaml#L342
If the shadows don't need access to globally add/remove milestones, I think website-milestone-maintainers
is the better place.
LMK what do you think.
/hold for resolution on the above
Add 1.21 Docs Shadows to GitHub teams Add 1.21 Docs Shadows to GitHub teams
@palnabarun I removed the shadows from the |
@reylejano -- Awesome! Thank you so much :) /lgtm |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: palnabarun, reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add 1.21 Docs Shadows to
website-milestone-maintainers
in sig-docs/teams.yaml andrelease-team
in sig-release/teams.yaml GitHub teams/assign @palnabarun @kikisdeliveryservice @savitharaghunathan @bai
/hold for feedback if shadows should be added to the
website-milestone-maintainers
team.I think they should have the ability to add the 1.21 milestone on kubernetes/website PRs.