Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add members 2020-01-10 #1544

Merged
merged 9 commits into from
Jan 10, 2020
Merged

Add members 2020-01-10 #1544

merged 9 commits into from
Jan 10, 2020

Conversation

mrbobbytables
Copy link
Member

fixes #1527
fixes #1532
fixes #1533
fixes #1534
fixes #1538
fixes #1539
fixes #1540
fixes #1542
fixes #1543

/area github-membership

@k8s-ci-robot k8s-ci-robot added area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2020
@mrbobbytables mrbobbytables mentioned this pull request Jan 10, 2020
Closed
6 tasks
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
This was referenced Jan 10, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@justaugustus
Copy link
Member

Welcome everyone!
/lgtm
/approve
/pony party

@k8s-ci-robot
Copy link
Contributor

@justaugustus: pony image

In response to this:

Welcome everyone!
/lgtm
/approve
/pony party

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2020
@justaugustus
Copy link
Member

/honk

@k8s-ci-robot
Copy link
Contributor

@justaugustus:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit eaf318c into kubernetes:master Jan 10, 2020
@mrbobbytables mrbobbytables deleted the add-members-2020-01-10 branch February 11, 2020 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

@ezzoueidi ezzoueidi Awaiting requested review from ezzoueidi

Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@mrbobbytables @justaugustus @k8s-ci-robot