Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update teams for external-dns #1353

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Update teams for external-dns #1353

merged 2 commits into from
Oct 30, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Oct 30, 2019

Ref: #1286

linki is a kubernetes org member and is automatically eligible for membership to kubernetes-sigs. All others mentioned in the issue are only kubernetes-incubator members, so they'll need to apply for membership to kubernetes-sigs.

/assign @mrbobbytables

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Oct 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019
@Raffo
Copy link
Contributor

Raffo commented Oct 30, 2019

All others mentioned in the issue are only kubernetes-incubator members, so they'll need to apply for membership to kubernetes-sigs.

@nikhita can you please provide information regarding the process to follow to apply for membership?

@nikhita nikhita mentioned this pull request Oct 30, 2019
Closed
@nikhita
Copy link
Member Author

nikhita commented Oct 30, 2019

@Raffo just commented here: #1286 (comment) :)

@mrbobbytables
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit efe5528 into kubernetes:master Oct 30, 2019
@nikhita nikhita deleted the external-dns-migrate branch October 30, 2019 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@mrbobbytables mrbobbytables

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikhita @k8s-ci-robot @Raffo @mrbobbytables