Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate bootkube to kubernetes-sigs #1305

Closed
aaronlevy opened this issue Oct 14, 2019 · 24 comments
Closed

Migrate bootkube to kubernetes-sigs #1305

aaronlevy opened this issue Oct 14, 2019 · 24 comments
Assignees
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.

Comments

@aaronlevy
Copy link

aaronlevy commented Oct 14, 2019

New Repo, Staging Repo, or migrate existing

migrate existing

Requested name for new repository

https://github.com/kubernetes-sigs/bootkube

Which Organization should it reside

kubernetes-sigs

If not a staging repo, who should have admin access

@aaronlevy

If not a staging repo, who should have write access

@aaronlevy

If not a staging repo, who should be listed as approvers in OWNERS

@aaronlevy

If not a staging repo, who should be listed in SECURITY_CONTACTS

@aaronlevy

What should the repo description be

Launch a self-hosted Kubernetes cluster

What SIG and subproject does this fall under in sigs.yaml

This is a new subproject for sig-cluster-lifecycle called bootkube

Approvals

I believe this is already technically part of sig-cluster-lifecycle (https://github.com/kubernetes/community/tree/master/sig-cluster-lifecycle#bootkube), but the repo was never moved.

/cc @kubernetes/sig-cluster-lifecycle

Additional context for request

Moving from deprecated kubernetes-incubator org.

Intention is to add community (and active SIG members) to OWNERS once this is moved. /cc @andrewrynhard @rmenn

@aaronlevy aaronlevy added the area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository label Oct 14, 2019
@nikhita
Copy link
Member

nikhita commented Oct 15, 2019

@aaronlevy Thanks for creating an issue to get this moving!

Regarding approval, we'll still need at least one lgtm from a SIG lead since this involves moving repos (albeit, in the kubernetes orgs).

/assign @timothysc @justinsb
for approval

@nikhita
Copy link
Member

nikhita commented Oct 15, 2019

xref kubernetes/community#1922

@nikhita nikhita added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Oct 15, 2019
@timothysc
Copy link
Member

@aaronlevy - How active is the project now-a-days? I was looking through the commit logs and if the most prevalent users are openshift, is there any other major consumers?

@rajugupta15
Copy link

Yes, In Razorpay, We are using bootkube.

@aaronlevy
Copy link
Author

aaronlevy commented Oct 16, 2019

Also the Talos Systems folks have been maintaining a fork, but would like to contribute back to the upstream project.

I haven't personally been able to spend much time on the project, but there has been interest from community members to pick up this effort / become maintainers. That's part of the reason for this move (can't add new people to incubator projects).

@timothysc
Copy link
Member

part of any project that would be submitted would be to evaluate the owners files and aliases to determine the health of the proposed sub-project. Could you please update https://github.com/kubernetes-incubator/bootkube/blob/master/OWNERS to reflect who the new owners are? If projects are not actively maintained then move them out of community resources. Also SIG chairs will need rights in order to manage the repo should it fall into disarray. Please update your OWNERS and OWNERS_ALIAS to reflect who are the maintainers (e.g. - https://github.com/kubernetes-sigs/cluster-api/blob/master/OWNERS_ALIASES)

@aaronlevy
Copy link
Author

Opened kubernetes-retired/bootkube#1051 and kubernetes-retired/bootkube#1052 to address this.

Bit of a chicken-egg problem on kubernetes-retired/bootkube#1051 - @rmenn isn't part of the org, but people aren't being added to incubator org anymore...

I could start by just adding @andrewrynhard for the sake of the project move - but will wait to hear your thoughts.

@timothysc
Copy link
Member

@rmenn @andrewrynhard - if you can confirm that would be useful.

@andrewrynhard
Copy link

@timothysc Yes please. We have a lot of updates to bootkube we would love to get in before the 1.17 k8s release. The sooner we can start, the better.

@rmenn
Copy link

rmenn commented Oct 25, 2019

@timothysc nope i am not a member of kubernetes-incubator, please feel free to add @andrewrynhard

@timothysc
Copy link
Member

@rmenn you will need todo a korg issue/request for access to the kubernetes-sigs org.

@rmenn
Copy link

rmenn commented Oct 25, 2019

will do, i did open this up, which is when this (#1282) pebble started rolling down the hill, will open once once everything is migrated

@rmenn
Copy link

rmenn commented Oct 25, 2019

opened #1343 TBD after migration

@rata
Copy link
Member

rata commented Oct 28, 2019

@aaronlevy - How active is the project now-a-days? I was looking through the commit logs and if the most prevalent users are openshift, is there any other major consumers?

We are using it in https://github.com/kinvolk/lokomotive-kubernetes too. We've just opened some PRs too :-)

@timothysc
Copy link
Member

Poke me when the OWNER file is finalized and folks have access to the org.

@aaronlevy
Copy link
Author

@timothysc The OWNERS and OWNERS_ALIASES have been updated.

@mrbobbytables
Copy link
Member

/assign

I'll move things over once theres ack from @timothysc 👍

@timothysc
Copy link
Member

@rmenn & @andrewrynhard - can you please apply for membership of kubernetes-sigs org once that is done then it we're good.

/lgtm
/approve
/hold
^ until they are added to the sigs org.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2019
@andrewrynhard
Copy link

andrewrynhard commented Oct 30, 2019

See #1357 for my Kubernetes-sigs membership request.

@rmenn
Copy link

rmenn commented Nov 1, 2019

@timothysc both of us are a part of the org, /hold can be removed

@timothysc
Copy link
Member

/hold cancel
@mrbobbytables - go for it.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2019
mrbobbytables pushed a commit to mrbobbytables/bootkube that referenced this issue Nov 7, 2019
SECURITY_CONTACTS updated with repo migration. For more information see: kubernetes/org#1305
@mrbobbytables
Copy link
Member

Once all remaining PRs are merged, the repo migration will be complete.

@mrbobbytables
Copy link
Member

All PRs have been merged. The repo has been migrated. I'm going to go ahead and close the issue. If you have any problems or questions, please feel free to reopen or ping me on slack :)

/close

@k8s-ci-robot
Copy link
Contributor

@mrbobbytables: Closing this issue.

In response to this:

All PRs have been merged. The repo has been migrated. I'm going to go ahead and close the issue. If you have any problems or questions, please feel free to reopen or ping me on slack :)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Development

No branches or pull requests

10 participants