Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stackdriver exporter #335

Merged
merged 4 commits into from
Sep 14, 2019
Merged

Add Stackdriver exporter #335

merged 4 commits into from
Sep 14, 2019

Conversation

xueweiz
Copy link
Contributor

@xueweiz xueweiz commented Aug 19, 2019 •
edited
Loading

Tested via:

TARBALL=npd.tar.gz make build-tar

PROJECT=xueweiz-experimental
INSTANCE=npd-test
gcloud compute --project=$PROJECT scp npd.tar.gz $INSTANCE:/tmp/npd.tar.gz
gcloud compute --project=$PROJECT scp ./test/e2e-install.sh $INSTANCE:/tmp/e2e-install.sh
gcloud compute --project=$PROJECT ssh $INSTANCE -- sudo bash /tmp/e2e-install.sh -t /tmp/npd.tar.gz install
gcloud compute --project=$PROJECT ssh $INSTANCE -- sudo bash

The Stackdriver exporter can be enabled via passing the --exporter.stackdriver option to NPD.
The Stackdriver exporter is included in NPD by default. Set environment variable BUILD_TAGS=disable_stackdriver_exporter when compiling NPD to disable it at compile time.

This is for #346

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @xueweiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 19, 2019
@xueweiz
Copy link
Contributor Author

xueweiz commented Aug 28, 2019

/assign @wangzhen127

@wangzhen127
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2019
wangzhen127
wangzhen127 reviewed Aug 30, 2019
View reviewed changes
cmd/nodeproblemdetector/node_problem_detector.go Show resolved Hide resolved
test/e2e-install.sh Outdated Show resolved Hide resolved
pkg/exporters/stackdriver/config/config.go Outdated Show resolved Hide resolved
pkg/exporters/stackdriver/metadata/type.go Outdated Show resolved Hide resolved
config/stackdriver-exporter.json Outdated Show resolved Hide resolved
cmd/options/options.go Outdated Show resolved Hide resolved
pkg/exporters/stackdriver/stackdriver_exporter.go Outdated Show resolved Hide resolved
pkg/exporters/stackdriver/stackdriver_exporter.go Outdated Show resolved Hide resolved
pkg/systemstatsmonitor/host_collector.go Show resolved Hide resolved
@xueweiz
Copy link
Contributor Author

xueweiz commented Sep 10, 2019

Hi Zhen, thanks for the review!
I just addressed to most of the items (except for making existing exporters into plugins, which I will look into tomorrow). Could you help take another look? Thanks!

@xueweiz
Copy link
Contributor Author

xueweiz commented Sep 10, 2019

/retest

wangzhen127
wangzhen127 reviewed Sep 11, 2019
View reviewed changes
Copy link
Member

@wangzhen127 wangzhen127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the readme file?

pkg/util/metrics/metric_id.go Outdated Show resolved Hide resolved
pkg/problemmetrics/problem_metrics.go Show resolved Hide resolved
pkg/util/metrics/metric_id.go Outdated Show resolved Hide resolved
pkg/util/metrics/metric_id.go Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
pkg/exporters/stackdriver/config/config.go Outdated Show resolved Hide resolved
pkg/exporters/stackdriver/config/config.go Show resolved Hide resolved
pkg/exporters/stackdriver/stackdriver_exporter.go Show resolved Hide resolved
pkg/exporters/stackdriver/gce/type.go Outdated Show resolved Hide resolved
pkg/exporters/stackdriver/stackdriver_exporter.go Outdated Show resolved Hide resolved
@xueweiz
Copy link
Contributor Author

xueweiz commented Sep 12, 2019

Hi Zhen, I just resolved the above comments and changed README. Can you help take another look? Thanks!

wangzhen127
wangzhen127 reviewed Sep 12, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
cmd/options/options.go Show resolved Hide resolved
@xueweiz xueweiz mentioned this pull request Sep 13, 2019
Closed
@wangzhen127
Copy link
Member

Can we move the last commit "Allow problem daemon plugins to define their command line options" to a different PR?

@xueweiz
Copy link
Contributor Author

xueweiz commented Sep 13, 2019

SG, filed #348 for the problem daemon plugin interface change. Thanks!

@wangzhen127
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wangzhen127, xueweiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit aea91e3 into kubernetes:master Sep 14, 2019
@xueweiz
Copy link
Contributor Author

xueweiz commented Sep 14, 2019

Thanks a lot Zhen!

@xueweiz xueweiz mentioned this pull request Sep 18, 2019
Closed
@xueweiz xueweiz mentioned this pull request Nov 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangzhen127 wangzhen127 wangzhen127 left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@wangzhen127 wangzhen127

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xueweiz @k8s-ci-robot @wangzhen127