Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make systemd monitor look back for 5m #319

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

wangzhen127
Copy link
Member

systemd monitor is currently used to detect kubelet/docker/containerd start events. This PR makes the monitor to look back for 5 minutes, which means, it checks the logs from the beginning when the node is booted.

When a node is booted on GKE, kubelet and docker are both restarted a few times, which can happen before or after NPD is started (NPD is running in standalone mode). If we look back for 5m, it should be enough for NPD to capture all the kubelet/docker/containerd start events from the boot time. This provides a complete picture of those components' health.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2019
@wangzhen127
Copy link
Member Author

/assign @Random-Liu
/cc @andyxning
/cc @xueweiz

@k8s-ci-robot
Copy link
Contributor

@wangzhen127: GitHub didn't allow me to request PR reviews from the following users: xueweiz.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @Random-Liu
/cc @andyxning
/cc @xueweiz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2019
@Random-Liu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Random-Liu,wangzhen127]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 239913c into kubernetes:master Aug 1, 2019
@wangzhen127 wangzhen127 deleted the systemd-monitor-fix branch August 2, 2019 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants