Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIC: Upgrade podman to version 2.2.0 and remove varlink #9636

Merged
merged 2 commits into from
Dec 8, 2020
Merged

KIC: Upgrade podman to version 2.2.0 and remove varlink #9636

merged 2 commits into from
Dec 8, 2020

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Nov 8, 2020 •
edited
Loading

Add the podman group, to remove "sudo varlink bridge"

Use the podman socket /run/podman/podman.sock instead

For #9638

Candidate for 1.17

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 8, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 8, 2020
@afbjorklund afbjorklund changed the title Upgrade podman to version 2.1.1 and remove varlink KIC: Upgrade podman to version 2.1.1 and remove varlink Nov 8, 2020
@afbjorklund afbjorklund changed the title KIC: Upgrade podman to version 2.1.1 and remove varlink WIP: KIC: Upgrade podman to version 2.1.1 and remove varlink Nov 8, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @afbjorklund,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test 
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.15.2.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.15.2.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.14.2 -X k8s.io/minikube/pkg/version.isoVersion=v1.14.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="5025f5fb67fdec588451d2ec42f8e764a375a302" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v3" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading github.com/pkg/errors v0.9.1
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200810185219-7d42fed1b770
go: downloading golang.org/x/crypto v0.0.0-20200820211705-5c72a883971a
go: downloading golang.org/x/exp v0.0.0-20200224162631-6cc2880d07d6
go: downloading k8s.io/api v0.17.3
go: downloading k8s.io/apimachinery v0.17.3
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading k8s.io/klog/v2 v2.4.0
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading k8s.io/kubernetes v1.18.5
go: downloading github.com/docker/go-units v0.4.0
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/blang/semver v3.5.0+incompatible
go: downloading k8s.io/client-go v0.17.3
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/spf13/viper v1.7.0
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading google.golang.org/api v0.25.0
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200902152226-fbad78ec2813
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading github.com/imdario/mergo v0.3.9
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading github.com/spf13/cobra v1.0.0
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading github.com/spf13/afero v1.2.2
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: downloading github.com/json-iterator/go v1.1.9
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading github.com/google/go-github v17.0.0+incompatible
go: downloading github.com/go-logr/logr v0.3.0
go: downloading github.com/sayboras/dockerclient v1.0.0
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading sigs.k8s.io/yaml v1.2.0
go: downloading github.com/magiconair/properties v1.8.1
go: downloading github.com/cloudevents/sdk-go/v2 v2.1.0
go: downloading github.com/otiai10/copy v1.0.2
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: downloading golang.org/x/text v0.3.2
go: downloading github.com/docker/go-connections v0.4.0
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading go.opencensus.io v0.22.3
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading go.uber.org/zap v1.10.0
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading cloud.google.com/go v0.57.0
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading google.golang.org/grpc v1.29.1
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner/v5 v5.0.0
go: downloading go.uber.org/multierr v1.1.0
go: downloading github.com/google/gofuzz v1.1.0
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading k8s.io/utils v0.0.0-20200324210504-a9aa75ae1b89
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading github.com/spf13/cast v1.3.1
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading github.com/golang/protobuf v1.4.2
go: downloading github.com/google/go-querystring v1.0.0
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading github.com/prometheus/client_golang v1.4.1
go: downloading k8s.io/kubectl v0.17.3
go: downloading google.golang.org/protobuf v1.24.0
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/fatih/color v1.9.0
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20201020145846-c0da14b4bffe
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/google/uuid v1.1.1
go: downloading github.com/miekg/dns v1.1.27
go: downloading go.uber.org/atomic v1.4.0
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading github.com/hashicorp/go-version v1.2.1
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading github.com/prometheus/common v0.9.1
go: downloading k8s.io/component-base v0.17.3
go: downloading github.com/ulikunitz/xz v0.5.7
go: downloading github.com/google/go-cmp v0.5.2
go: downloading github.com/lightstep/tracecontext.go v0.0.0-20181129014701-1757c391b1ac
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading github.com/prometheus/procfs v0.0.8
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading k8s.io/kube-openapi v0.0.0-20200410145947-61e04a5be9a6
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
--- FAIL: TestGenerateDocs (0.03s)
    --- FAIL: TestGenerateDocs/addons (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 17 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for addons
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 22 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for configure
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 22 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for disable
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 9 identical lines
              	      --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging
              	```
            - 	
            - 	## minikube addons enable
            - 	
            - 	Enables the addon w/ADDON_NAME within minikube (example: minikube addons enable dashboard). For a list of available addons use: minikube addons list 
              	
            - 	### Synopsis
            + 	## minikube addons enable
              	... // 136 identical, 19 removed, and 13 inserted lines
              	"""
              )
    --- FAIL: TestGenerateDocs/cache (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 13 identical lines
              	Add, delete, or push a local image into minikube
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for cache
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 22 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for add
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 22 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for delete
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 9 identical lines
              	      --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging
              	```
            - 	
            - 	## minikube cache help
            - 	
            - 	Help about any command
              	
            - 	### Synopsis
            + 	## minikube cache help
              	... // 94 identical, 19 removed, and 13 inserted lines
              	"""
              )
    --- FAIL: TestGenerateDocs/completion (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 36 identical lines
              	```
              	minikube completion SHELL [flags]
            - 	```
            - 	
            - 	### Options
            - 	
            - 	```
            - 	  -h, --help   help for completion
              	```
              	
              	... // 4 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/config (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 47 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for config
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 28 identical lines
              	
              	```
            - 	  -h, --help            help for defaults
              	      --output string   Output format. Accepted values: [json]
              	```
              	... // 5 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 22 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for get
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 23 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for help
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 9 identical lines
              	      --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging
              	```
            - 	
            - 	## minikube config set
            - 	
            - 	Sets an individual value in a minikube config file
              	... // 95 identical, 20 removed, and 14 inserted lines
              	"""
              )
    --- FAIL: TestGenerateDocs/dashboard (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   strings.Join({
              	... // 20 identical lines
              	"",
              	"```",
            - 	"  -h, --help   help for dashboard",
            - 	"      --url    Display dashboard URL instead of opening a browser",
            + 	"      --url   Display dashboard URL instead of opening a browser",
              	"```",
              	"",
              	... // 4 identical lines
              	"      --alsologtostderr                  log to standard error as well as files",
              	`  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")`,
            + 	"  -h, --help                             ",
              	"      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)",
              	"      --log_dir string                   If non-empty, write log files in this directory",
              	... // 13 identical lines
              }, "\n")
    --- FAIL: TestGenerateDocs/delete (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 22 identical lines
              	```
              	      --all     Set flag to delete all profiles
            - 	  -h, --help    help for delete
              	      --purge   Set this flag to delete the '.minikube' folder from your user directory.
              	```
              	... // 5 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/docker-env (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
            �� 	"""
              	... // 20 identical lines
              	
              	```
            - 	  -h, --help           help for docker-env
              	      --no-proxy       Add machine IP to NO_PROXY environment variable
              	      --shell string   Force environment to be configured for a specified shell: [fish, cmd, powershell, tcsh, bash, zsh], default is auto-detect
              	... // 7 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/ip (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 15 identical lines
              	```
              	minikube ip [flags]
            - 	```
            - 	
            - 	### Options
            - 	
            - 	```
            - 	  -h, --help   help for ip
              	```
              	
              	... // 4 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/kubectl (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 19 identical lines
              	```
              	minikube kubectl [flags]
            - 	```
            - 	
            - 	### Options
            - 	
            - 	```
            - 	  -h, --help   help for kubectl
              	```
              	
              	... // 4 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/logs (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 21 identical lines
              	```
              	  -f, --follow        Show only the most recent journal entries, and continuously print new entries as they are appended to the journal.
            - 	  -h, --help          help for logs
              	  -n, --length int    Number of lines back to go within the log (default 60)
              	      --node string   The node to get logs from. Defaults to the primary control plane.
              	... // 7 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/mount (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 22 identical lines
              	      --9p-version string   Specify the 9p version that the mount should use (default "9p2000.L")
              	      --gid string          Default group id used for the mount (default "docker")
            - 	  -h, --help                help for mount
              	      --ip string           Specify the ip that the mount should be setup on
              	      --kill                Kill the mount process spawned by minikube start
              	... // 11 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/node (0.01s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 17 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for node
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 27 identical lines
              	      --control-plane       If true, the node added will also be a control plane in addition to a worker.
              	      --delete-on-failure   If set, delete the current cluster if start fails and try again. Defaults to false.
            - 	  -h, --help                help for add
              	      --worker              If true, the added node will be marked for work. Defaults to true. (default true)
              	```
              	... // 5 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 22 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for delete
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 23 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for help
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 9 identical lines
              	      --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging
              	```
            - 	
            - 	## minikube node list
            - 	
            - 	List nodes.
              	... // 95 identical, 18 removed, and 12 inserted lines
              	"""
              )
    --- FAIL: TestGenerateDocs/pause (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 22 identical lines
              	  -n, ----namespaces strings   namespaces to pause (default [kube-system,kubernetes-dashboard,storage-gluster,istio-operator])
              	  -A, --all-namespaces         If set, pause all namespaces
            - 	  -h, --help                   help for pause
              	  -o, --output string          Format to print stdout in. Options include: [text,json] (default "text")
              	```
              	... // 5 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/podman-env (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 20 identical lines
              	
              	```
            - 	  -h, --help           help for podman-env
              	      --shell string   Force environment to be configured for a specified shell: [fish, cmd, powershell, tcsh, bash, zsh], default is auto-detect
              	  -u, --unset          Unset variables instead of setting them
              	... // 6 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/profile (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 17 identical lines
              	```
              	
            - 	### Options
            + 	### Options inherited from parent commands
              	
              	```
            - 	  -h, --help   help for profile
            - 	```
            - 	
            - 	### Options inherited from parent commands
            - 	
            - 	```
              	      --add_dir_header                   If true, adds the file directory to the header of the log messages
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	
              	Help about any command
            - 	
            - 	### Synopsis
            - 	
            - 	Help provides help for any command in the application.
            - 	Simply type profile help [path to command] for full details.
              	
            - 	```
            - 	minikube profile help [command] [flags]
            - 	```
            + 	### Synopsis
              	
            - 	### Options
            + 	Help provides help for any command in the application.
            + 	Simply type profile help [path to command] for full details.
              	
              	```
            - 	  -h, --help   help for help
            + 	minikube profile help [command] [flags]
              	```
              	
              	... // 4 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 25 identical lines
              	
              	```
            - 	  -h, --help            help for list
              	  -o, --output string   The output format. One of 'json', 'table' (default "table")
              	```
              	... // 5 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/service (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 21 identical lines
              	```
              	      --format string      Format to output service URL in. This format will be applied to each url individually and they will be printed one at a time. (default "http://{{.IP}}:{{.Port}}")
            - 	  -h, --help               help for service
              	      --https              Open the service URL with https instead of http (defaults to "false")
              	      --interval int       The initial time interval for each check that wait performs in seconds (default 1)
              	... // 9 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 18 identical lines
              	Help provides help for any command in the application.
              	Simply type service help [path to command] for full details.
            - 	
            - 	```
            - 	minikube service help [command] [flags]
            - 	```
            - 	
            - 	### Options
              	
              	```
            - 	  -h, --help   help for help
            + 	minikube service help [command] [flags]
              	```
              	
              	... // 5 identical lines
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
              	      --format string                    Format to output service URL in. This format will be applied to each url individually and they will be printed one at a time. (default "http://{{.IP}}:{{.Port}}")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 25 identical lines
              	
              	```
            - 	  -h, --help               help for list
              	  -n, --namespace string   The services namespace
              	```
              	... // 6 identical lines
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
              	      --format string                    Format to output service URL in. This format will be applied to each url individually and they will be printed one at a time. (default "http://{{.IP}}:{{.Port}}")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/ssh (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 20 identical lines
              	
              	```
            - 	  -h, --help          help for ssh
              	      --native-ssh    Use native Golang SSH client (default true). Set to 'false' to use the command line 'ssh' command when accessing the docker machine. Useful for the machine drivers when they will not start with 'Waiting for SSH'. (default true)
              	  -n, --node string   The node to ssh into. Defaults to the primary control plane.
              	... // 6 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/ssh-key (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 15 identical lines
              	```
              	minikube ssh-key [flags]
            - 	```
            - 	
            - 	### Options
            - 	
            - 	```
            - 	  -h, --help   help for ssh-key
              	```
              	
              	... // 4 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/start (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 51 identical lines
              	      --force                             Force minikube to perform possibly dangerous operations
              	      --force-systemd                     If set, force the container runtime to use sytemd as cgroup manager. Currently available for docker and crio. Defaults to false.
            - 	  -h, --help                              help for start
              	      --host-dns-resolver                 Enable host resolver for NAT DNS requests (virtualbox driver only) (default true)
              	      --host-only-cidr string             The CIDR to be used for the minikube VM (virtualbox driver only) (default "192.168.99.1/24")
              	... // 45 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/status (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 24 identical lines
              	  -f, --format string   Go template format string for the status output.  The format for Go templates can be found here: https://golang.org/pkg/text/template/
              	                        For the list accessible variables for the template, see the struct values here: https://godoc.org/k8s.io/minikube/cmd/minikube/cmd#Status (default "{{.Name}}\ntype: Control Plane\nhost: {{.Host}}\nkubelet: {{.Kubelet}}\napiserver: {{.APIServer}}\nkubeconfig: {{.Kubeconfig}}\n\n")
            - 	  -h, --help            help for status
              	  -l, --layout string   output layout (EXPERIMENTAL, JSON only): 'nodes' or 'cluster' (default "nodes")
              	  -n, --node string     The node to check status for. Defaults to control plane. Leave blank with default format for status on all nodes.
              	... // 7 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/stop (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 21 identical lines
              	```
              	      --all                   Set flag to stop all profiles (clusters)
            - 	  -h, --help                  help for stop
              	      --keep-context-active   keep the kube-context active after cluster is stopped. Defaults to false.
              	  -o, --output string         Format to print stdout in. Options include: [text,json] (default "text")
              	... // 6 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/tunnel (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 21 identical lines
              	```
              	  -c, --cleanup   call with cleanup=true to remove old tunnels (default true)
            - 	  -h, --help      help for tunnel
              	```
              	
              	... // 4 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/unpause (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 22 identical lines
              	  -n, ----namespaces strings   namespaces to unpause (default [kube-system,kubernetes-dashboard,storage-gluster,istio-operator])
              	  -A, --all-namespaces         If set, unpause all namespaces
            - 	  -h, --help                   help for unpause
              	  -o, --output string          Format to print stdout in. Options include: [text,json] (default "text")
              	```
              	... // 5 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/update-check (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 15 identical lines
              	```
              	minikube update-check [flags]
            - 	```
            - 	
            - 	### Options
            - 	
            - 	```
            - 	  -h, --help   help for update-check
              	```
              	
              	... // 4 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/update-context (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 16 identical lines
              	```
              	minikube update-context [flags]
            - 	```
            - 	
            - 	### Options
            - 	
            - 	```
            - 	  -h, --help   help for update-context
              	```
              	
              	... // 4 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
    --- FAIL: TestGenerateDocs/version (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   (
              	"""
              	... // 20 identical lines
              	
              	```
            - 	  -h, --help            help for version
              	  -o, --output string   One of 'yaml' or 'json'.
              	      --short           Print just the version number.
              	... // 6 identical lines
              	      --alsologtostderr                  log to standard error as well as files
              	  -b, --bootstrapper string              The name of the cluster bootstrapper that will set up the Kubernetes cluster. (default "kubeadm")
            + 	  -h, --help                             
              	      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
              	      --log_dir string                   If non-empty, write log files in this directory
              	... // 13 identical lines
              	"""
              )
E1108 19:19:22.473883   12100 out.go:142] [unset errFile]: ! Local proxy ignored: not passing HTTP_PROXY=127.0.0.1:3128 to docker env.
E1108 19:19:22.474386   12100 out.go:142] [unset errFile]: ! Local proxy ignored: not passing HTTP_PROXY=127.0.0.1:3128 to docker env.
E1108 19:19:22.474509   12100 out.go:142] [unset errFile]: ! Local proxy ignored: not passing HTTP_PROXY=localhost:3128 to docker env.
E1108 19:19:22.474702   12100 out.go:142] [unset errFile]: ! Local proxy ignored: not passing HTTP_PROXY=localhost:3128 to docker env.
E1108 19:19:22.474801   12100 out.go:142] [unset errFile]: ! Local proxy ignored: not passing HTTP_PROXY=http://localhost:3128 to docker env.
E1108 19:19:22.474971   12100 out.go:142] [unset errFile]: ! Local proxy ignored: not passing HTTP_PROXY=http://localhost:3128 to docker env.
E1108 19:19:22.475075   12100 out.go:142] [unset errFile]: ! Local proxy ignored: not passing HTTP_PROXY=http://127.0.0.1:3128 to docker env.
E1108 19:19:22.475245   12100 out.go:142] [unset errFile]: ! Local proxy ignored: not passing HTTP_PROXY=http://127.0.0.1:3128 to docker env.
FAIL
coverage: 18.5% of statements
FAIL	k8s.io/minikube/cmd/minikube/cmd	4.430s
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.039s	coverage: 21.0% of statements
ok  	k8s.io/minikube/pkg/addons	0.072s	coverage: 50.9% of statements
ok  	k8s.io/minikube/pkg/drivers	0.023s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.002s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kic/oci	0.018s	coverage: 6.4% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.028s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	1.043s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.121s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.020s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.006s	coverage: 82.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.059s	coverage: 14.5% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.050s	coverage: 4.2% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.130s	coverage: 68.1% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.056s	coverage: 36.7% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.055s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.023s	coverage: 40.1% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.007s	coverage: 58.6% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.031s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.033s	coverage: 81.3% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.004s	coverage: 49.3% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.041s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.072s	coverage: 35.8% of statements
ok  	k8s.io/minikube/pkg/minikube/mustload	0.083s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.031s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.024s	coverage: 66.0% of statements
ok  	k8s.io/minikube/pkg/minikube/out/register	0.007s	coverage: 54.5% of statements
ok  	k8s.io/minikube/pkg/minikube/perf	4.018s	coverage: 21.1% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.010s	coverage: 68.7% of statements
ok  	k8s.io/minikube/pkg/minikube/reason	0.008s	coverage: 80.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.010s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.071s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.006s	coverage: 97.1% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.033s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/style	0.003s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.033s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.010s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.932s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	1.013s	coverage: 75.7% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.005s	coverage: 22.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.004s	coverage: 0.0% of statements
FAIL
Makefile:315: recipe for target 'test' failed
make: *** [test] Error 32
travis_time:end:0f6329be:start=1604863051045659882,finish=1604863210822351253,duration=159776691371,event=script
TravisBuddy Request Identifier: 11191850-21fa-11eb-a04c-b76cbd6ddda3

@RA489 RA489 mentioned this pull request Nov 13, 2020
Closed
@afbjorklund
Upgrade podman to version 2.1.1 and remove varlink
a8754ad 
Add the podman group, to remove "sudo varlink bridge"

Use the podman socket /run/podman/podman.sock instead
@afbjorklund afbjorklund changed the title WIP: KIC: Upgrade podman to version 2.1.1 and remove varlink KIC: Upgrade podman to version 2.1.1 and remove varlink Nov 14, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2020
@afbjorklund
Copy link
Collaborator Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2020
@afbjorklund afbjorklund changed the title KIC: Upgrade podman to version 2.1.1 and remove varlink KIC: Upgrade podman to version 2.2.0 and remove varlink Dec 1, 2020
@afbjorklund afbjorklund added this to the v1.17.0-candidate milestone Dec 1, 2020
@afbjorklund afbjorklund mentioned this pull request Dec 7, 2020
Closed
@medyagh medyagh merged commit 4a0382f into kubernetes:master Dec 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@afbjorklund @TravisBuddy @k8s-ci-robot @medyagh