new --wait component "kubelet" #9459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Codecov Report
@@ Coverage Diff @@
## master #9459 +/- ##
=======================================
Coverage 29.05% 29.05%
=======================================
Files 171 171
Lines 10444 10443 -1
=======================================
Hits 3034 3034
+ Misses 6988 6987 -1
Partials 422 422
|
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
medyagh
changed the title
|
kvm2 Driver Times for Minikube (PR 9459): 60.4s 60.9s 60.1s Averages Time Per Log docker Driver Times for Minikube (PR 9459): 28.3s 29.4s 29.0s Averages Time Per Log |
k8s-ci-robot
added
the
needs-rebase
priyawadhwa
reviewed
Oct 13, 2020
medyagh
force-pushed
the
stopped_kubelet
branch
from
1bc0626
to
ad83c72
Compare
k8s-ci-robot
removed
the
needs-rebase
Travis tests have failedHey @medyagh, 1st Buildmake test2nd Buildmake test3rd BuildmakeTravisBuddy Request Identifier: b779d800-0da6-11eb-9111-f326d0cb7f09 |
|
kvm2 Driver Times for Minikube (PR 9459): 57.7s 60.4s 58.4s Averages Time Per Log docker Driver Times for Minikube (PR 9459): 26.8s 28.4s 27.2s Averages Time Per Log |
Travis tests have failedHey @medyagh, 1st Buildmake test2nd Buildmake test3rd BuildmakeTravisBuddy Request Identifier: debb5d60-0da8-11eb-9111-f326d0cb7f09 |
Travis tests have failedHey @medyagh, 1st Buildmake test2nd Buildmake test3rd BuildmakeTravisBuddy Request Identifier: 291afa00-0da9-11eb-9111-f326d0cb7f09 |
medyagh
changed the title
|
kvm2 Driver Times for Minikube (PR 9459): 60.1s 59.1s 60.0s Averages Time Per Log docker Driver Times for Minikube (PR 9459): 27.5s 29.2s 27.4s Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 9459): 60.4s 64.4s 62.3s Averages Time Per Log docker Driver Times for Minikube (PR 9459): 29.6s 26.8s 27.5s Averages Time Per Log |
priyawadhwa
reviewed
Oct 14, 2020
|
kvm2 Driver Times for Minikube (PR 9459): 59.8s 63.5s 62.7s Averages Time Per Log docker Driver Times for Minikube (PR 9459): 27.1s 28.1s 27.4s Averages Time Per Log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while this does NOT fix the issue #9456 it might help to get to the bottom of it.
this adds a new wait component which is not enabled by default.
if user passes --wait=all it will wait for everything including kubelet