-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase preload version to v6 #9159
Conversation
We upgraded the dashboard image in kubernetes#9129, this will rebuild tarballs to include the latest version. This should also fix a small performance regression, where start time was increased by 25% on kvm2, probably becaues we were waiting for the new dashboard image to download. [PR bot comment](kubernetes#9129 (comment))
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think that once one image is missing from the preload, it gives up on all the other ones too. Actually it only does a retrieve, which re-downloads the manifest - but the layers are still there |
/ok-to-test |
@priyawadhwa - can you approve #9151 first? |
kvm2 Driver Times for Minikube (PR 9159): 114.2s 104.3s 100.5s Averages Time Per Log
docker Driver Times for Minikube (PR 9159): 59.1s 58.3s 59.5s Averages Time Per Log
|
We upgraded the dashboard image in #9129, this will rebuild tarballs to include the latest version.
This should also fix a small performance regression, where start time was increased by 25% on kvm2, probably because preload failed and we were waiting for the new dashboard image to download. PR bot comment