Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an new flag to stop command --keep-context-active #9044

Merged
merged 2 commits into from
Aug 21, 2020
Merged

add an new flag to stop command --keep-context-active #9044

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9cfbd0
add an new flag to stop command --keep-context-active
medyagh Aug 20, 2020
200fddd
gen doc
medyagh Aug 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cmd/minikube/cmd/stop.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import (
)

var stopAll bool
var keepActive bool

// stopCmd represents the stop command
var stopCmd = &cobra.Command{
Expand All @@ -51,6 +52,7 @@ itself, leaving all files intact. The cluster can be started again with the "sta
func init() {

stopCmd.Flags().BoolVar(&stopAll, "all", false, "Set flag to stop all profiles (clusters)")
stopCmd.Flags().BoolVar(&keepActive, "keep-context-active", false, "keep the kube-context active after cluster is stopped. Defaults to false.")

if err := viper.GetViper().BindPFlags(stopCmd.Flags()); err != nil {
exit.WithError("unable to bind flags", err)
Expand Down Expand Up @@ -111,8 +113,10 @@ func stopProfile(profile string) int {
out.WarningT("Unable to kill mount process: {{.error}}", out.V{"error": err})
}

if err := kubeconfig.UnsetCurrentContext(profile, kubeconfig.PathFromEnv()); err != nil {
exit.WithError("update config", err)
if !keepActive {
if err := kubeconfig.UnsetCurrentContext(profile, kubeconfig.PathFromEnv()); err != nil {
exit.WithError("update config", err)
}
}

return stoppedNodes
Expand Down