Upgrade docker driver base image to v0.0.10 #7858
Conversation
The dockerfile currently doesn't build because it can't find the specified versions of crio and podman to install.
k8s-ci-robot
added
the
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
kvm2 Driver |
|
Failing Tests TestStartStop/group/containerd - 533.86s coredns pod: TestStartStop/group/crio - 1175.54s TestStartStop/group/embed-certs - 724.03s |
This will happen again, neither Ubuntu nor Kubic makes any guarantees to keep old packages... If you want to keep "pinning" packages, then we need to create a cache of all the .deb used: lz4=1.9.1-1 cri-o-1.17=1.17.3~2 podman=1.9.0~2 Including all implicit dependencies, in case there are version specifics in those as well ? Instead we should probably either use ranges, or remove the version-release pinning. |
|
@afbjorklund that's a really good point. I'm not sure what the best solution here is -- for now, I've added the This isn't a great solution because if the order of Dockerfile commands changes the cache will probably be invalidated, so I think we should definitely keep thinking about this |
|
kvm2 Driver Times for Minikube (PR 7858): [65.315666595 68.31352301499999 68.43029887] Averages Time Per Log docker Driver Times for Minikube (PR 7858): [27.131350208999997 26.741041884999994 35.446674972] Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 7858): [66.09855355 68.881941169 66.587829424] Averages Time Per Log docker Driver Times for Minikube (PR 7858): [26.344396718999995 35.891610876 26.795944348999996] Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 7858): [65.06875039799999 64.236856385 66.72048402499999] Averages Time Per Log docker Driver Times for Minikube (PR 7858): [27.110970461 26.565326333000005 25.801958952000003] Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 7858): [65.92526135600002 66.66427920199999 69.339560821] Averages Time Per Log docker Driver Times for Minikube (PR 7858): [26.693685580000004 26.903694577 26.982727319] Averages Time Per Log |
|
@priyawadhwa @medyagh : we need to add the "varlink" package to the kicbase, for podman-env Whatever version is available from the Kubic repository is fine, so just add it after "podman" ? |
|
@afbjorklund thanks for the heads up, added. |
Codecov Report
@@ Coverage Diff @@
## master #7858 +/- ##
==========================================
- Coverage 35.60% 35.50% -0.10%
==========================================
Files 148 148
Lines 9305 9330 +25
==========================================
Hits 3313 3313
- Misses 5595 5620 +25
Partials 397 397
|
|
kvm2 Driver Times for Minikube (PR 7858): [64.53194879499999 64.5584059 64.082664652] Averages Time Per Log docker Driver Times for Minikube (PR 7858): [31.001312109 26.130894519 27.839061300999997] Averages Time Per Log |
The dockerfile currently doesn't build because it can't find the specified versions of crio and podman to install.