Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --base-image flag for docker driver local dev #7856

Merged
merged 4 commits into from
Apr 23, 2020
Merged

Add --base-image flag for docker driver local dev #7856

merged 4 commits into from
Apr 23, 2020

Conversation

priyawadhwa
Copy link

@priyawadhwa priyawadhwa commented Apr 22, 2020 •
edited by medyagh
Loading

Pass in the base image you want to use for the docker/podman drivers

Now,

minikube start --driver docker --base-image kic

works if kic is an image in the local daemon

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2020
@priyawadhwa
Copy link
Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 22, 2020
@codecov-io
Copy link

Codecov Report

Merging #7856 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7856   +/-   ##
=======================================
  Coverage   35.57%   35.57%           
=======================================
  Files         148      148           
  Lines        9297     9298    +1     
=======================================
+ Hits         3307     3308    +1     
  Misses       5593     5593           
  Partials      397      397
Impacted Files Coverage Δ
cmd/minikube/cmd/start_flags.go 50.98% <100.00%> (+0.16%) ⬆️

@priyawadhwa priyawadhwa mentioned this pull request Apr 22, 2020
Closed
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [64.067869588 66.74683219999997 68.18603397199999]
Average time for minikube: 66.33357858666666

Times for Minikube (PR 7856): [65.021858464 66.35148583899998 66.352587265]
Average time for Minikube (PR 7856): 65.90864385600001

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7856) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.0 on   |  0.066265 |           0.063439 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.020009 |           0.021891 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003063 |           0.003368 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.198134 |          40.772724 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.839160 |          22.665785 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.511341 |           1.814774 |
| components...                  |           |                    |
| * Enabled addons:              |  0.614468 |           0.482834 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.077882 |           0.078110 |
| configured to use "minikube"   |           |                    |
|                                |  0.003257 |           0.005719 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.721481762 28.325761596 29.358377784000005]
Average time for minikube: 28.135207047333335

Times for Minikube (PR 7856): [28.033911286000002 29.044211214 26.912825133000002]
Average time for Minikube (PR 7856): 27.996982544333335

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7856) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.0 on           |  0.078196 |           0.082291 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002574 |           0.002878 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.062308 |           0.060518 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.093362 |           7.939699 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000230 |           0.000245 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.667735 |          18.364820 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.157424 |           1.469203 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.002618 |           0.002883 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.066623 |           0.066482 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004136 |           0.007964 |
+----------------------------------------+-----------+--------------------+

medyagh
medyagh requested changes Apr 22, 2020
View reviewed changes
cmd/minikube/cmd/start_flags.go Outdated Show resolved Hide resolved
medyagh
medyagh requested changes Apr 22, 2020
View reviewed changes
site/content/en/docs/commands/start.md Outdated Show resolved Hide resolved
medyagh
medyagh approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with optional comment

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [65.26812048699999 64.494469727 64.491857659]
Average time for minikube: 64.75148262433333

Times for Minikube (PR 7856): [66.02737067199999 65.921100724 64.80613917899998]
Average time for Minikube (PR 7856): 65.58487019166667

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7856) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.0 on   |  0.063126 |           0.063581 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.020950 |           0.023396 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003316 |           0.003368 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.458743 |          41.097315 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 21.679150 |          22.334683 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.444533 |           1.470236 |
| components...                  |           |                    |
| * Enabled addons:              |  1.002059 |           0.496834 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.075574 |           0.090047 |
| configured to use "minikube"   |           |                    |
|                                |  0.004032 |           0.005411 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.723042108 26.636060121000003 27.453483369000004]
Average time for minikube: 27.270861866

Times for Minikube (PR 7856): [27.624064225 27.053634655000003 26.571612191]
Average time for Minikube (PR 7856): 27.083103690333335

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7856) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.0 on           |  0.080831 |           0.090275 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.003008 |           0.002509 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.063900 |           0.061751 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.009227 |           8.034759 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000249 |           0.000265 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.869022 |          17.853406 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.174247 |           0.867044 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.002675 |           0.097410 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.064536 |           0.068639 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003164 |           0.007047 |
+----------------------------------------+-----------+--------------------+

@afbjorklund
Copy link
Collaborator

Sounds good, before you had to hack the code in order to use the "snapshot" images.

@priyawadhwa priyawadhwa changed the title Add --docker-base-image flag for docker driver local dev Add --base-image flag for docker driver local dev Apr 23, 2020
@priyawadhwa priyawadhwa merged commit 8f42f38 into kubernetes:master Apr 23, 2020
@priyawadhwa priyawadhwa deleted the devkic branch April 23, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@priyawadhwa @k8s-ci-robot @codecov-io @minikube-pr-bot @afbjorklund @medyagh