Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fish completion support #7777

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

sayboras
Copy link
Contributor

@sayboras sayboras commented Apr 19, 2020

Fixes #7778

asciicast

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @sayboras. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 19, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sayboras
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

codecov-io commented Apr 19, 2020

Codecov Report

Merging #7777 into master will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7777      +/-   ##
==========================================
- Coverage   35.87%   35.82%   -0.05%     
==========================================
  Files         148      148              
  Lines        9201     9213      +12     
==========================================
  Hits         3301     3301              
- Misses       5504     5516      +12     
  Partials      396      396              
Impacted Files Coverage Δ
cmd/minikube/cmd/completion.go 0.00% <0.00%> (ø)

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 19, 2020
@sayboras sayboras force-pushed the feature/fish-completion branch 3 times, most recently from d184683 to 38b34d4 Compare April 19, 2020 06:31
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 19, 2020
@medyagh
Copy link
Member

medyagh commented Apr 19, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [64.215297486 63.68365241 63.930432116999995]
Average time for minikube: 63.943127337666674

Times for Minikube (PR 7777): [65.94558338799999 65.867662439 63.96495110000001]
Average time for Minikube (PR 7777): 65.25939897566667

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7777) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.056941 |           0.055858 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019062 |           0.018326 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.004777 |           0.004630 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.025663 |          40.461909 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 20.809850 |          22.789042 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  0.000833 |           0.001415 |
| Components:                    |           |                    |
|   - verifying node conditions  |  0.001536 |           0.003323 |
| ...                            |           |                    |
|   - verifying api server ...   |  0.065120 |           0.117971 |
|   - verifying system pods ...  |  1.312518 |           1.393051 |
| * Enabled addons:              |  0.571522 |           0.341748 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.072331 |           0.067579 |
| configured to use "minikube"   |           |                    |
|                                |  0.002975 |           0.004547 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.222878659 27.423056600000002 28.004515942]
Average time for minikube: 27.216817066999997

Times for Minikube (PR 7777): [25.992819670999992 25.170288622999994 26.747727469000004]
Average time for Minikube (PR 7777): 25.970278587666666

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7777) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.070735 |           0.071366 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002509 |           0.002302 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.053415 |           0.055405 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.518145 |           7.221371 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000249 |           0.000408 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 16.836720 |          16.870733 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.001333 |           0.001860 |
| Components:                            |           |                    |
|   - verifying node conditions          |  0.004104 |           0.002095 |
| ...                                    |           |                    |
|   - verifying api server ...           |  0.060476 |           0.100260 |
|   - verifying system pods ...          |  2.602937 |           1.578061 |
| * Enabled addons:                      |  0.002292 |           0.002504 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.060312 |           0.060453 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003591 |           0.003460 |
+----------------------------------------+-----------+--------------------+

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this PR

@medyagh medyagh merged commit ae7c923 into kubernetes:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto completion support for fish
6 participants