-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fish completion support #7777
Conversation
Hi @sayboras. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sayboras The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e9d9473
to
fb1a39b
Compare
Codecov Report
@@ Coverage Diff @@
## master #7777 +/- ##
==========================================
- Coverage 35.87% 35.82% -0.05%
==========================================
Files 148 148
Lines 9201 9213 +12
==========================================
Hits 3301 3301
- Misses 5504 5516 +12
Partials 396 396
|
d184683
to
38b34d4
Compare
/ok-to-test |
kvm2 Driver Times for Minikube (PR 7777): [65.94558338799999 65.867662439 63.96495110000001] Averages Time Per Log
docker Driver Times for Minikube (PR 7777): [25.992819670999992 25.170288622999994 26.747727469000004] Averages Time Per Log
|
38b34d4
to
66a7cf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for this PR
Fixes #7778