-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default CNI network for running wth podman #7754
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -29,6 +29,8 @@ endef | |||
|
|||
define PODMAN_INSTALL_TARGET_CMDS | |||
$(INSTALL) -Dm755 $(@D)/bin/podman $(TARGET_DIR)/usr/bin/podman | |||
$(INSTALL) -d -m 755 $(TARGET_DIR)/etc/cni/net.d/ | |||
$(INSTALL) -m 644 cni/87-podman-bridge.conflist $(TARGET_DIR)/etc/cni/net.d/87-podman-bridge.conflist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this something we could add to ubuntu image too ? kicbase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, it is already included (provided by podman
package):
docker@minikube:~$ dpkg -S /etc/cni/net.d/87-podman-bridge.conflist
podman: /etc/cni/net.d/87-podman-bridge.conflist
If you do a sudo make install
in libpod, it will be included by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work OK there, with the provided CNI:
docker@minikube:~$ sudo podman run -it busybox
Trying to pull docker.io/library/busybox...
Getting image source signatures
Copying blob e2334dd9fee4 done
Copying config be5888e67b done
Writing manifest to image destination
Storing signatures
/ #
So this was only a missing file on the minikube VM
/ok-to-test |
/retest-this-please |
kvm2 Driver |
Forgot to add this after #6664
For #7709