Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart crio after applying the kic overlay (in background) #7575

Merged
merged 3 commits into from
Apr 10, 2020

Conversation

tstromberg
Copy link
Contributor

Based on @afbjorklund's observations, this may fix #7380

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 10, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #7575 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7575   +/-   ##
=======================================
  Coverage   36.49%   36.49%           
=======================================
  Files         147      147           
  Lines        9109     9109           
=======================================
  Hits         3324     3324           
  Misses       5398     5398           
  Partials      387      387           

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [62.532054754 63.065207868 64.001064821]
Average time for minikube: 63.199442481

Times for Minikube (PR 7575): [63.50373002399999 62.695124952 64.814630323]
Average time for Minikube (PR 7575): 63.67116176633334

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7575) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.050170 |           0.050250 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.015921 |           0.016314 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.002755 |           0.002680 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.044546 |          40.591663 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 21.238183 |          20.823934 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  1.756167 |           2.113432 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.088043 |           0.069115 |
| configured to use "minikube"   |           |                    |
|                                |  0.003657 |           0.003774 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [36.728949906000004 44.441060648000004 43.968003609]
Average time for minikube: 41.71267138766666

Times for Minikube (PR 7575): [45.098499815 44.76021034399999 45.043927322]
Average time for Minikube (PR 7575): 44.967545827

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7575) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.062966 |           0.062634 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002049 |           0.002155 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.000111 |           0.000123 |
| minikube in cluster minikube           |           |                    |
| * Pulling base image ...               |  0.147443 |           0.148759 |
| * Creating Kubernetes in               |  9.160523 |           9.201441 |
| docker container with (CPUs=2)         |           |                    |
| (4 available), Memory=3700MB           |           |                    |
| (15043MB available) ...                |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.095082 |           0.093004 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 30.716411 |          31.115537 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  1.450335 |           4.198821 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.074443 |           0.141527 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003309 |           0.003544 |
+----------------------------------------+-----------+--------------------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker driver + crio: failed to set bridge addr: could not add IP address to "cni0": permission denied
4 participants