-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rejection reason to 'unable to find driver' error #7379
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #7379 +/- ##
=======================================
Coverage 37.18% 37.19%
=======================================
Files 145 145
Lines 8836 8851 +15
=======================================
+ Hits 3286 3292 +6
- Misses 5154 5162 +8
- Partials 396 397 +1
|
for _, ds := range options { | ||
if ds != pick { | ||
if !ds.State.Healthy || !ds.State.Installed { | ||
glog.Errorf("%s: %s", ds.Name, ds.Rejection) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like all this logic could be done in one loop instead of two, though I'm not sure if there's a real advantage of either strategy.
Otherwise this PR is great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but I wasn't smart enough to figure out how without making it overly complicated.
We aren't sure who to pick until the end of the first loop - so no matter what, we need to iterate twice to part out the alternates. I'l leave this for someone better at reasoning about algorithms.
/ok-to-test |
Error: running mkcmp: exit status 1 |
Our current error message is not as helpful as it could be:
💣 Unable to determine a default driver to use. Try specifying --driver, or see https://minikube.sigs.k8s.io/docs/start/
Here is the new error message this PR proposes:
Solves mysteries such as #7371