-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for virtualbox users to set nat-nic-type #5960
Conversation
Welcome @davidnewman! |
Hi @davidnewman. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davidnewman The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
/assign @tstromberg |
Codecov Report
@@ Coverage Diff @@
## master #5960 +/- ##
==========================================
+ Coverage 36.09% 36.13% +0.03%
==========================================
Files 110 110
Lines 8208 8212 +4
==========================================
+ Hits 2963 2967 +4
Misses 4854 4854
Partials 391 391
|
Thanks for this pr! |
/ok-to-test |
Thank you for this PR |
Fixes #5959
Before:
minikube start --vm-driver=virtualbox
After:
minikube start --vm-driver=virtualbox --nat-nic-type=82545EM
OR
minikube start --vm-driver=virtualbox --host-only-nic-type=82545EM
OR
minikube start --vm-driver=virtualbox --host-only-nic-type=82545EM --nat-nic-type=82545EM
Default behavior is unchanged and
virtio
will be used as NIC type for both networks when the arguments are not supplied.