Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for virtualbox users to set nat-nic-type #5960

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

davidnewman
Copy link
Contributor

Fixes #5959

Before:

minikube start --vm-driver=virtualbox

After:

minikube start --vm-driver=virtualbox --nat-nic-type=82545EM

OR

minikube start --vm-driver=virtualbox --host-only-nic-type=82545EM

OR

minikube start --vm-driver=virtualbox --host-only-nic-type=82545EM --nat-nic-type=82545EM

Default behavior is unchanged and virtio will be used as NIC type for both networks when the arguments are not supplied.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @davidnewman!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @davidnewman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidnewman
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@davidnewman
Copy link
Contributor Author

/assign @tstromberg

@codecov-io
Copy link

Codecov Report

Merging #5960 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5960      +/-   ##
==========================================
+ Coverage   36.09%   36.13%   +0.03%     
==========================================
  Files         110      110              
  Lines        8208     8212       +4     
==========================================
+ Hits         2963     2967       +4     
  Misses       4854     4854              
  Partials      391      391
Impacted Files Coverage Δ
cmd/minikube/cmd/start.go 20% <100%> (+0.46%) ⬆️

@medyagh
Copy link
Member

medyagh commented Nov 23, 2019

Thanks for this pr!

@medyagh
Copy link
Member

medyagh commented Nov 23, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 23, 2019
@medyagh
Copy link
Member

medyagh commented Nov 25, 2019

Thank you for this PR

@medyagh medyagh changed the title Users can set nat-nic-type and host-only-nic-type Add option for virtualbox users to set nat-nic-type Nov 25, 2019
@medyagh medyagh merged commit 8a4c7d3 into kubernetes:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to control NIC type when using virtualbox vm-driver
6 participants