Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory and wait longer for TestFunctional tests, include node logs #5852

Merged
merged 5 commits into from
Nov 11, 2019

Conversation

tstromberg
Copy link
Contributor

This is my attempt to address, or at least make it easier to debug a failure seen at https://storage.googleapis.com/minikube-builds/logs/5845/KVM_Linux.txt

--- FAIL: TestFunctional (1108.40s)
    --- FAIL: TestFunctional/parallel (0.00s)
        --- FAIL: TestFunctional/parallel/ServiceCmd (247.55s)
            functional_test.go:401: (dbg) Run:  kubectl --context functional-20191106T184708.612171223-5083 create deployment hello-node --image=gcr.io/hello-minikube-zero-install/hello-node
            functional_test.go:401: (dbg) Done: kubectl --context functional-20191106T184708.612171223-5083 create deployment hello-node --image=gcr.io/hello-minikube-zero-install/hello-node: (1.254451042s)
            functional_test.go:405: (dbg) Run:  kubectl --context functional-20191106T184708.612171223-5083 expose deployment hello-node --type=NodePort --port=8080
            functional_test.go:405: (dbg) Done: kubectl --context functional-20191106T184708.612171223-5083 expose deployment hello-node --type=NodePort --port=8080: (3.561272622s)
            functional_test.go:410: (dbg) waiting for pods with labels "app=hello-node" in namespace "default" ...
            helpers.go:247: "hello-node-7676b5fb8d-snnft" [c70b0f59-1ae8-4f80-9120-22b6eadc421e] Pending
            helpers.go:247: "hello-node-7676b5fb8d-snnft" [c70b0f59-1ae8-4f80-9120-22b6eadc421e] Pending / Ready:ContainersNotReady (containers with unready status: [hello-node]) / ContainersReady:ContainersNotReady (containers with unready status: [hello-node])
            functional_test.go:410: pod "app=hello-node" failed to start: timed out waiting for the condition
            helpers.go:292: (dbg) Run:  kubectl --context functional-20191106T184708.612171223-5083 get po -A --show-labels
            helpers.go:298: (dbg) kubectl --context functional-20191106T184708.612171223-5083 get po -A --show-labels:
                NAMESPACE              NAME                                         READY   STATUS              RESTARTS   AGE     LABELS
                default                busybox                                      1/1     Running             0          2m48s   integration-test=busybox
                default                busybox-mount                                0/1     Completed           0          111s    integration-test=busybox-mount
                default                hello-node-7676b5fb8d-snnft                  0/1     ContainerCreating   0          4m2s    app=hello-node,pod-template-hash=7676b5fb8d
                default                mysql-5787d7b5fc-4sjk4                       1/1     Running             0          7m4s    app=mysql,pod-template-hash=5787d7b5fc
                default                nginx-svc                                    1/1     Running             0          5m23s   run=nginx-svc
                kube-system            coredns-5644d7b6d9-sdvrw                     1/1     Running             0          15m     k8s-app=kube-dns,pod-template-hash=5644d7b6d9
                kube-system            coredns-5644d7b6d9-wzhdg                     1/1     Running             0          15m     k8s-app=kube-dns,pod-template-hash=5644d7b6d9
                kube-system            etcd-minikube                                1/1     Running             0          14m     component=etcd,tier=control-plane
                kube-system            kube-addon-manager-minikube                  1/1     Running             0          15m     component=kube-addon-manager,kubernetes.io/minikube-addons=addon-manager,version=v9.0.2
                kube-system            kube-apiserver-minikube                      1/1     Running             0          14m     component=kube-apiserver,tier=control-plane
                kube-system            kube-controller-manager-minikube             1/1     Running             0          14m     component=kube-controller-manager,tier=control-plane
                kube-system            kube-proxy-6b6kz                             1/1     Running             0          15m     controller-revision-hash=56ffd4ff47,k8s-app=kube-proxy,pod-template-generation=1
                kube-system            kube-scheduler-minikube                      1/1     Running             0          14m     component=kube-scheduler,tier=control-plane
                kube-system            storage-provisioner                          1/1     Running             0          15m     addonmanager.kubernetes.io/mode=Reconcile,integration-test=storage-provisioner
                kubernetes-dashboard   dashboard-metrics-scraper-76585494d8-tt46m   0/1     ContainerCreating   0          46s     k8s-app=dashboard-metrics-scraper,pod-template-hash=76585494d8
                kubernetes-dashboard   kubernetes-dashboard-57f4cb4545-94lpv        0/1     ContainerCreating   0          46s     k8s-app=kubernetes-dashboard,pod-template-hash=57f4cb4545

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2019
@medyagh
Copy link
Member

medyagh commented Nov 6, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 6, 2019
@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #5852 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5852      +/-   ##
=========================================
- Coverage   36.53%   36.5%   -0.04%     
=========================================
  Files         110     110              
  Lines        8116    8123       +7     
=========================================
  Hits         2965    2965              
- Misses       4762    4769       +7     
  Partials      389     389
Impacted Files Coverage Δ
cmd/minikube/cmd/start.go 19.79% <0%> (-0.21%) ⬇️

@minikube-bot
Copy link
Collaborator

All Times minikube: [ 186.168547 175.981677 196.728886]
All Times Minikube (PR 5852): [ 204.676825 172.879580 198.404401]

Average minikube: 186.293037
Average Minikube (PR 5852): 191.986935

Averages Time Per Log

+------------------------+-----------+--------------------+
|          LOG           | MINIKUBE  | MINIKUBE (PR 5852) |
+------------------------+-----------+--------------------+
| minikube v             |  0.355435 |           0.293899 |
| Creating kvm2          | 41.906969 |          41.384504 |
| Preparing Kubernetes   | 56.483649 |          53.269897 |
| Pulling images         |  3.022505 |           2.760402 |
| Launching Kubernetes   | 22.109443 |          21.210833 |
| Waiting for: apiserver | 62.415036 |          73.067401 |
+------------------------+-----------+--------------------+

@minikube-bot
Copy link
Collaborator

All Times Minikube (PR 5852): [ 179.127122 193.238174 182.356118]
All Times minikube: [ 171.310579 173.289692 187.943145]

Average minikube: 177.514472
Average Minikube (PR 5852): 184.907138

Averages Time Per Log

+------------------------+-----------+--------------------+
|          LOG           | MINIKUBE  | MINIKUBE (PR 5852) |
+------------------------+-----------+--------------------+
| minikube v             |  0.257717 |           0.252958 |
| Creating kvm2          | 39.991336 |          38.010474 |
| Preparing Kubernetes   | 49.669551 |          48.817670 |
| Pulling images         |  2.656805 |           2.611525 |
| Launching Kubernetes   | 19.044692 |          19.143574 |
| Waiting for: apiserver | 65.894371 |          76.070937 |
+------------------------+-----------+--------------------+

@minikube-bot
Copy link
Collaborator

All Times Minikube (PR 5852): [ 194.299917 192.063852 187.144028]
All Times minikube: [ 163.661837 191.066565 188.801800]

Average Minikube (PR 5852): 191.169266
Average minikube: 181.176734

Averages Time Per Log

+------------------------+-----------+--------------------+
|          LOG           | MINIKUBE  | MINIKUBE (PR 5852) |
+------------------------+-----------+--------------------+
| minikube v             |  0.335619 |           0.316537 |
| Creating kvm2          | 38.169169 |          39.286193 |
| Preparing Kubernetes   | 48.365970 |          51.372516 |
| Pulling images         |  2.530945 |           2.853858 |
| Launching Kubernetes   | 19.376174 |          19.775251 |
| Waiting for: apiserver | 72.398857 |          77.564910 |
+------------------------+-----------+--------------------+

@tstromberg tstromberg merged commit 8b2d7c8 into kubernetes:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants