Make error message more human readable

pkg/minikube/service/service.go

@@ -275,7 +275,7 @@ func WaitAndMaybeOpenService(api libmachine.API, namespace string, service strin
 	chkSVC := func() error { return CheckService(namespace, service) }
 
 	if err := retry.Expo(chkSVC, time.Duration(interval)*time.Second, time.Duration(wait)*time.Second); err != nil {
-		return errors.Wrapf(err, "Could not find finalized endpoint being pointed to by %s", service)
+		return errors.Wrapf(err, "Service %s was not found in default namespace , please try with 'minikube service %s -n Y'", service, service)
 	}
 
 	serviceURL, err := GetServiceURLsForService(api, namespace, service, urlTemplate)

pkg/minikube/service/service_test.go

@@ -97,6 +97,27 @@ var serviceNamespaces = map[string]typed_core.ServiceInterface{
 	"default": defaultNamespaceServiceInterface,
 }
 
+var nondefaultserviceNamespaces = map[string]typed_core.ServiceInterface{
+	"default": nondefaultNamespaceServiceInterface,
+}
+
+var nondefaultNamespaceServiceInterface = &MockServiceInterface{
+	ServiceList: &core.ServiceList{
+		Items: []core.Service{
+			{
+				ObjectMeta: meta.ObjectMeta{
+					Name:      "non-namespace-dashboard-no-ports",
+					Namespace: "non-default",
+					Labels:    map[string]string{"mock": "mock"},
+				},
+				Spec: core.ServiceSpec{
+					Ports: []core.ServicePort{},
+				},
+			},
+		},
+	},
+}
+
 var defaultNamespaceServiceInterface = &MockServiceInterface{
 	ServiceList: &core.ServiceList{
 		Items: []core.Service{
@@ -824,6 +845,7 @@ func TestWaitAndMaybeOpenService(t *testing.T) {
 		urlMode     bool
 		https       bool
 		err         bool
+		nondefault  bool
 	}{
 		/*	{
 			description: "no host",
@@ -841,13 +863,15 @@ func TestWaitAndMaybeOpenService(t *testing.T) {
 			api:         defaultAPI,
 			https:       true,
 			expected:    []string{"http://127.0.0.1:1111", "http://127.0.0.1:2222"},
+			nondefault:  false,
 		},
 		{
 			description: "correctly return serviceURLs, no https, no url mode",
 			namespace:   "default",
 			service:     "mock-dashboard",
 			api:         defaultAPI,
 			expected:    []string{"http://127.0.0.1:1111", "http://127.0.0.1:2222"},
+			nondefault:  false,
 		},
 		{
 			description: "correctly return serviceURLs, no https, url mode",
@@ -856,6 +880,7 @@ func TestWaitAndMaybeOpenService(t *testing.T) {
 			api:         defaultAPI,
 			urlMode:     true,
 			expected:    []string{"http://127.0.0.1:1111", "http://127.0.0.1:2222"},
+			nondefault:  false,
 		},
 		{
 			description: "correctly return serviceURLs, https, url mode",
@@ -865,6 +890,7 @@ func TestWaitAndMaybeOpenService(t *testing.T) {
 			urlMode:     true,
 			https:       true,
 			expected:    []string{"http://127.0.0.1:1111", "http://127.0.0.1:2222"},
+			nondefault:  false,
 		},
 		{
 			description: "correctly return empty serviceURLs",
@@ -873,14 +899,31 @@ func TestWaitAndMaybeOpenService(t *testing.T) {
 			api:         defaultAPI,
 			expected:    []string{},
 			err:         true,
+			nondefault:  false,
+		},
+		{
+			description: "correctly return empty serviceURLs",
+			namespace:   "default",
+			service:     "non-namespace-dashboard-no-ports",
+			api:         defaultAPI,
+			expected:    []string{},
+			err:         true,
+			nondefault:  true,
 		},
 	}
 	defer revertK8sClient(K8s)
 	for _, test := range tests {
 		t.Run(test.description, func(t *testing.T) {
-			K8s = &MockClientGetter{
-				servicesMap:  serviceNamespaces,
-				endpointsMap: endpointNamespaces,
+			if test.nondefault {
+				K8s = &MockClientGetter{
+					servicesMap:  nondefaultserviceNamespaces,
+					endpointsMap: endpointNamespaces,
+				}
+			} else {
+				K8s = &MockClientGetter{
+					servicesMap:  serviceNamespaces,
+					endpointsMap: endpointNamespaces,
+				}
 			}
 			err := WaitAndMaybeOpenService(test.api, test.namespace, test.service, defaultTemplate, test.urlMode, test.https, 1, 0)
 			if test.err && err == nil {

test.sh

@@ -20,7 +20,7 @@ TESTSUITE="${TESTSUITE:-all}" # if env variable not set run all the tests
 exitcode=0
 
 if [[ "$TESTSUITE" = "lint" ]] || [[ "$TESTSUITE" = "all" ]]
-then 
+then
     echo "= make lint ============================================================="
     make -s lint-ci && echo ok || ((exitcode += 4))
     echo "= go mod ================================================================"