Refactor command runner interface, allow stdin writes #5530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
medyagh
changed the title
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Travis tests have failedHey @medyagh, 1st Buildmake test2nd Buildmake testTravisBuddy Request Identifier: 83023ec0-e569-11e9-950a-c74496fc22d4 |
Travis tests have failedHey @medyagh, 1st Buildmake test2nd Buildmake testTravisBuddy Request Identifier: 7d3218b0-e62e-11e9-9927-991e8c29daea |
Codecov Report
@@ Coverage Diff @@
## master #5530 +/- ##
==========================================
- Coverage 37.83% 36.62% -1.22%
==========================================
Files 106 110 +4
Lines 7773 8093 +320
==========================================
+ Hits 2941 2964 +23
- Misses 4452 4740 +288
- Partials 380 389 +9
|
Travis tests have failedHey @medyagh, 1st Buildmake testTravisBuddy Request Identifier: bbeea290-e6d2-11e9-9927-991e8c29daea |
Travis tests have failedHey @medyagh, 1st Buildmake test2nd Buildmake testTravisBuddy Request Identifier: 6caef200-e6e3-11e9-9927-991e8c29daea |
Travis tests have failedHey @medyagh, 1st Buildmake test2nd Buildmake testTravisBuddy Request Identifier: 160f7bc0-e6ea-11e9-9927-991e8c29daea |
Travis tests have failedHey @medyagh, 1st Buildmake test2nd Buildmake testTravisBuddy Request Identifier: 6cb7dc90-e6ec-11e9-9927-991e8c29daea |
medyagh
added
do-not-test
medyagh
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
medyagh
added
ok-to-test
|
/retest this please |
medyagh
force-pushed
the
NewCmdRunner
branch
2 times, most recently
from
ed491fb
to
29a015b
Compare
|
tstromberg
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
tstromberg
suggested changes
Oct 29, 2019
|
tstromberg
suggested changes
Oct 29, 2019
Linux Vbox FailureWeird error on Linux virtualbox integration test: None Faliurethe one time that none passedFor the record, the time that it passed was on Build #6235 (Oct 29, 2019 2:54:49) on GCP - Linux This one acted as a flake ! when I updated the PR for a un-realted Wrap format, it went from green to red. I wonder if this is related to which VM the CI job lands on ? VM :Linux GCP - Linux |
|
/ok-to-test |
|
Flakes appear unrelated. Merging. |
I believe I've fixed this. It seemed that the GPU machine had a bad KVM-SPICE config. I deinstalled the SPICE driver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially this is preparing minikube to use kic ! (which requires setting StdIn on the commands)
previously minikube commands were all string, now it would be a exec.Cmd interface type.
This PR:
cmd string