Makefile improvements for the kvm2 driver #4779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should respect the MINIKUBE_BUILD_IN_DOCKER param, and also make the "docker inspect" output less verbose And make the windows target repeatable, by leaving the original output binary (copy instead of move) behind
Make sure that we don't link with libvirt 2.0.0+ by mistake. Don't need to link the LXC library, as we are not using it.
docker://gcr.io/k8s-minikube/kvm-build-image:latest
k8s-ci-robot
added
cncf-cla: yes
afbjorklund
requested review from
josedonizetti
and removed request for
sharifelgamal and
RA489
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
josedonizetti
approved these changes
Jul 17, 2019
|
If we are building the drivers in docker now, then we probably don't need to install libvirt-dev locally ? before_install:
- sudo apt-get install -y libvirt-dev
install:
- echo "Don't run anything."
|
tstromberg
changed the title
tstromberg
approved these changes
Jul 17, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #4751
Improve the targets for the kvm2 driver, and make sure to build it using the Ubuntu 16.04 docker image.
Until the
gcr.io/k8s-minikube/kvm-build-imageimage has been uploaded, build it when necessary...Double-check the linking of the final binary, to make sure that we have actually fixed #4555
#3689