-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move supported drivers per platform #4738
Move supported drivers per platform #4738
Conversation
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: josedonizetti The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To be honest I'm not sure why even bother with plugins, if we are hard-coding the list of "supported" ones anyway ? It's not like you can add your own, since `minikube' will just complain that it is not supported... But since we are going the way of validating the drivers (#4720), then maybe this makes the code prettier/smaller. And first glance it just looks like duplication, but maybe that can be cleaned up a bit ? |
@afbjorklund I don't see it the same way. I understood this At the same time, no strong feeling about all this we can close both PRs. :) |
I’m all for filtering out the invalid drivers (i.e. not available on platform) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@minikube-bot OK to test
1362248
to
254dac5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure Parallels is not supported on Windows.
Apparently it got cancelled. https://www.parallels.com/blogs/parallels-desktop-for-windows/ |
254dac5
to
2ed16a1
Compare
This is something
minishift
do and is pretty useful. Wdyt?