Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add warn about old driver version (hyperkit, kvm) #4681

Closed
wants to merge 1 commit into from
Closed

WIP: Add warn about old driver version (hyperkit, kvm) #4681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pkg/minikube/problem/err_map.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ var vmProblems = map[string]match{
URL: "https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#hyperkit-driver",
Issues: []int{1926, 4206},
},
"OLD_HYPERKIT_VERSION": {
Regexp: re(`Add warn about old driver version (hyperkit, kvm)`),
Copy link
Member

@josedonizetti josedonizetti Jul 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which message is this regexp matching? Do you have an example of where this message is displayed to the user?

Advice: "Too old hyperkit version. Jump forward to new valid hyperkit version as a workaround.",
URL: "https://github.com/kubernetes/minikube/blob/master/docs/drivers.md"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
URL: "https://github.com/kubernetes/minikube/blob/master/docs/drivers.md"
URL: "https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#hyperkit-upgrade",

There's a specific link for hyperkit upgrade. Also missing a comma at the end.

Issues: []int{4658},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add URL to documentation on how to upgrade.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this doc: https://github.com/kubernetes/minikube/blob/master/docs/drivers.md

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

},
"VBOX_NOT_FOUND": {
Regexp: re(`VBoxManage not found. Make sure VirtualBox is installed and VBoxManage is in the path`),
Advice: "Install VirtualBox, ensure that VBoxManage is executable and in path, or select an alternative value for --vm-driver",
Expand Down Expand Up @@ -119,6 +125,12 @@ var vmProblems = map[string]match{
URL: "http://mikko.repolainen.fi/documents/virtualization-with-kvm",
Issues: []int{2991},
},
"OLD_KVM_VERSION": {
Regexp: re(`Too old KVM version found`),
Copy link
Member

@josedonizetti josedonizetti Jul 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which message is this regexp matching? Do you have an example of where this message is displayed to the user?

Advice: "too old KVM version. Jump forward to new valid KVM version as a workaround.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add URL to documentation on how to upgrade.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josedonizetti done!

URL: "https://github.com/kubernetes/minikube/blob/master/docs/drivers.md"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
URL: "https://github.com/kubernetes/minikube/blob/master/docs/drivers.md"
URL: "https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#kvm2-upgrade",

There's a specific link for kvm upgrade. Also missing a comma at the end.

Issues: []int{4658},
},
"KVM_CONNECTION_ERROR": {
Regexp: re(`error connecting to libvirt socket`),
Advice: "Have you set up libvirt correctly?",
Expand Down