Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ingress-NGINX to 0.24.1 Release #4583

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Conversation

fenglixa
Copy link
Contributor

Update Ingress-NGINX to 0.24.1 Release
Fix for #4578

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @fenglixa. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fenglixa
To complete the pull request process, please assign sharifelgamal
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@fenglixa
Copy link
Contributor Author

I append my UT result here:
image

@minikube-bot OK to test

@medyagh
Copy link
Member

medyagh commented Jun 25, 2019

@minikube-bot OK to test

@medyagh medyagh self-assigned this Jun 25, 2019
@medyagh
Copy link
Member

medyagh commented Jun 25, 2019

Thank you for this PR ! it is exciting to see minikube bugs getting closed one after another.
@fenglixa have you tried the ingress change on your computer locally ? I would recommend deploying a service with ingress and check if it is acting normal

@medyagh medyagh added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2019
@fenglixa
Copy link
Contributor Author

Thanks @medyagh .
Yes, I created the services and ingress resources, it works well with the code changes.
image

@medyagh medyagh added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2019
@medyagh
Copy link
Member

medyagh commented Jun 25, 2019

Awesome, thank you so much for the contribution. closes this #4578

@medyagh medyagh merged commit a85eac1 into kubernetes:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants