-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor kvm lookupIPFromStatusFile #4334
Refactor kvm lookupIPFromStatusFile #4334
Conversation
Hi @josedonizetti. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: josedonizetti If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@minikube-bot OK to test |
1 similar comment
@minikube-bot OK to test |
There are a few problems with the kvm
lookupIPFromStatusFile
.1 - when the IP is found, it keeps executing the for instead of returning directly.
2 - it ignores the
json.Unmarshal
error due to a 'possible' empty fileThis PR refactor the code to:
1 - return as soon as the IP match was found
2 - not ignore the JSON error, in case of an empty file it returns blank, but if the JSON itself is invalid we report the error because it means a possible error on the KVM installation of the user, which worths notifying.
3 - add tests to this logic
For the tests, I've used the same convention I saw for the hyperkit tests.