Return host IP when using vmware as vm driver.

[ne0h]

Adds the missing case "vmware" to return the host IP.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Hi @ne0h. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[ne0h]

Signed CLA.

[tstromberg]

Hey ne0h!

I'm a bit confused by this PR: the title says it implements mounting, but the PR adds an IP.

Can you elaborate some in the PR description as to how the two are related? Thanks!

[tstromberg]

@minikube-bot OK to test

[ne0h]

Hey @tstromberg, you are absolutely right. I updated the commit and the description of the PR to be more applicable.

[ne0h]

Given that host.Driver.GetIP() returns the guest IP address reliably, the switch statement could be removed completely?

[tstromberg]

Given that host.Driver.GetIP() returns the guest IP address reliably, the switch statement could be removed completely?

I wonder about this. I'd be happy to merge this PR as is, but if this simplification works, that's great. I'm concerned however that some drivers may have different values for host.Driver.GetIP() and the VM-Host IP, but the integration tests should catch that. Feel free to propose in a different PR if you like.

[tstromberg]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ne0h, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tstromberg]

To be consistent with the others, I think you can just call:

return net.ParseIP(vmIPstring), nil