-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit of logviewer addon #3391
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ivans3 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
@minikube-bot OK to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ivans3 - thank you for the contribution. I am worried about endorsing this addon just yet because the logviewer
- has binaries (xtail) in the github repo instead of traceable/trustworthy places - this needs to be fixed with checksums/etc.
- is a couple of months old but it looks like it has not seen much usage yet, no issues/PRs have been opened
- has only 1 contributor - theoretically addons are "well maintained" - installing products backed by potentially more than 1 person.
Idea: maybe you could start a "Community addons" section here that could point to your repository. That might generate enough traffic and interest?
Hi @balopat , Thanks for your feedback and suggestions, I really appreciate it! The xtail binary is built from debian source only adding the "-static" option to the build. So you are saying to abandon this PR for now, and make a new one only for the addons.md file |
https://github.com/ivans3/minikube-log-viewer