-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #3044 - mounted timestamps incorrect with windows host #3285
Conversation
…correct with windows host.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Can one of the admins verify this patch? |
@minikube-bot OK to test |
@tstromberg I've managed to reproduce these failures on my linux box. I think it might be related to the msize default for the mount command being too large for the tests. I'm currently investigating. |
Only check access time is set for windows OS.
@minikube-bot OK to test |
Do you mind addressing the merge conflict? I'd like to see about merging this if it's still viable. My apologies for the unnecessarily long delay in reviewing this PR. |
Will do - I'll take a look over the weekend. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ngoozeff If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Test cases & resolution for #3044.
Original Behavior:
With this fix: