Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minikube tunnel #3015
minikube tunnel #3015
Changes from 40 commits
8fb3edb
c04b84d
a7d124d
dcf208e
9e73808
34c5d88
2114e4c
228ed39
94d19b1
9080b0e
e70d66a
25f46c7
8ef4fe2
5895fef
efeaace
f16460a
a7f5f28
10a716a
a475aa3
701bfe0
edbe1b7
8158a92
b264ebf
4efd3e0
3edb93f
5cf91e0
0e6f9dc
f2e0ee0
157eeef
2dbcd93
7accb7d
6116038
cb45876
9b94eb0
a695115
ace1146
295dce0
76e5d9d
a7b0c54
8f05699
bcd9a43
5fc3490
1323e56
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind describing how leaving this default to False helps users? Would it otherwise cleanup tunnels that are still useful to them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can change it to auto-cleanup and try cleaning up every time, as cleanup does leave the useful tunnels (still running ones) in place. I was just operating under the assumption that
tunnel --cleanup
would be a separate command for handling the "unclean shutdown" cases - which should be rare.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cleanup command is supposed to only cleanup routes that are exact matches of minikube CIDR -> minikube IP and the process should not be running. The chances that a user has created an exact same route that she doesn't want deleted is minimal, so I guess we can safely include this at the start as well.
However a standalone cleanup command is still useful to have without having to start a tunnel command -
minikube tunnel --cleanup
does just that.