Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux steps are for without VM #2500

Merged
merged 1 commit into from
Feb 5, 2018
Merged

linux steps are for without VM #2500

merged 1 commit into from
Feb 5, 2018

Conversation

kmova
Copy link
Contributor

@kmova kmova commented Feb 2, 2018

The steps indicate minikube is getting installed without VM
sudo -E ./minikube start --vm-driver=none

The steps indicate minikube is getting installed without VM
sudo -E ./minikube start --vm-driver=none
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kmova
We suggest the following additional approver: aaron-prindle

Assign the PR to them by writing /assign @aaron-prindle in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@afbjorklund
Copy link
Collaborator

Confusingly, I think the comment was alluding to the fact that running minikube this way allows ("supports" ?) running it inside another VM, referred to as "nested virtualization" further down on the page...

none (Linux-only) - this driver can be used to run the Kubernetes cluster components on the host instead of in a VM. This can be useful for CI workloads which do not support nested virtualization.

Would be good with some extra clarification.

@kmova
Copy link
Contributor Author

kmova commented Feb 3, 2018

I see what you mean @afbjorklund

Though, I must say, I find this mode (vmdriver=none) useful for non-CI workload scenarios as well.

@afbjorklund
Copy link
Collaborator

afbjorklund commented Feb 3, 2018

Yeah, that is another documentation need... Especially with the addition of kubeadm bootstrapper.

@dlorenc
Copy link
Contributor

dlorenc commented Feb 5, 2018

I think this initially was intended to mean that you can run it inside a VM, but this seems slightly more clear. We probably want to reword it more though.

@dlorenc dlorenc merged commit ff9671f into kubernetes:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants