-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for kubeadm.k8s.io/v1beta4 available since k8s v1.31 #19790
Conversation
Hi @fbyrne. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I branched off the AMD support, just ignore that commit it will be removed when the PR gets merged. |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be branched off of your AMD plugin changes, since that's merged now would you mind rebasing.
Edit: I just read your message above now
suggestions applied and rebased. |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 54.2s 50.9s 49.5s 48.5s 49.1s Times for minikube ingress: 15.0s 17.9s 19.0s 15.0s 16.0s docker driver with docker runtime
Times for minikube start: 21.4s 21.0s 21.6s 24.0s 22.5s Times for minikube ingress: 13.3s 12.3s 12.2s 12.3s 12.8s docker driver with containerd runtime
Times for minikube start: 22.5s 22.9s 19.2s 19.6s 19.8s Times for minikube ingress: 32.8s 39.3s 38.8s 39.2s 38.7s |
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbyrne, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #19788
Adds support for kubeadm.k8s.io/v1beta4 available since k8s v1.31
https://kubernetes.io/blog/2024/08/23/kubernetes-1-31-kubeadm-v1beta4/