Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for kubeadm.k8s.io/v1beta4 available since k8s v1.31 #19790

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

fbyrne
Copy link
Contributor

@fbyrne fbyrne commented Oct 11, 2024

fixes #19788

Adds support for kubeadm.k8s.io/v1beta4 available since k8s v1.31

https://kubernetes.io/blog/2024/08/23/kubernetes-1-31-kubeadm-v1beta4/

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 11, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @fbyrne. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 11, 2024
@fbyrne
Copy link
Contributor Author

fbyrne commented Oct 11, 2024

I branched off the AMD support, just ignore that commit it will be removed when the PR gets merged.

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@fbyrne fbyrne changed the title Feature/19788 Adds support for kubeadm.k8s.io/v1beta4 available since k8s v1.31 Oct 11, 2024
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be branched off of your AMD plugin changes, since that's merged now would you mind rebasing.

Edit: I just read your message above now

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 12, 2024
@fbyrne
Copy link
Contributor Author

fbyrne commented Oct 12, 2024

suggestions applied and rebased.

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19790) |
+----------------+----------+---------------------+
| minikube start | 50.4s    | 49.8s               |
| enable ingress | 16.6s    | 15.9s               |
+----------------+----------+---------------------+

Times for minikube start: 54.2s 50.9s 49.5s 48.5s 49.1s
Times for minikube (PR 19790) start: 49.0s 49.9s 47.6s 50.7s 52.0s

Times for minikube ingress: 15.0s 17.9s 19.0s 15.0s 16.0s
Times for minikube (PR 19790) ingress: 14.5s 16.0s 14.9s 15.0s 19.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19790) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 22.6s               |
| enable ingress | 12.6s    | 12.8s               |
+----------------+----------+---------------------+

Times for minikube start: 21.4s 21.0s 21.6s 24.0s 22.5s
Times for minikube (PR 19790) start: 23.4s 24.4s 21.5s 22.9s 20.5s

Times for minikube ingress: 13.3s 12.3s 12.2s 12.3s 12.8s
Times for minikube (PR 19790) ingress: 12.8s 12.8s 12.7s 12.8s 12.7s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19790) |
+----------------+----------+---------------------+
| minikube start | 20.8s    | 22.2s               |
| enable ingress | 37.8s    | 38.8s               |
+----------------+----------+---------------------+

Times for minikube start: 22.5s 22.9s 19.2s 19.6s 19.8s
Times for minikube (PR 19790) start: 22.5s 22.3s 22.7s 23.5s 20.0s

Times for minikube ingress: 32.8s 39.3s 38.8s 39.2s 38.7s
Times for minikube (PR 19790) ingress: 38.8s 38.8s 38.7s 38.7s 38.8s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbyrne, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@spowelljr spowelljr merged commit c080701 into kubernetes:master Oct 14, 2024
33 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for kubeadm v1beta4
5 participants