Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go from 1.21.6 to 1.22.0 #18197

Merged

Conversation

minikube-bot
Copy link
Collaborator

Kubernetes Project just updated the golang version, updating minikube golang to match Kubernetes.

This PR was auto-generated by make update-golang-version using update-golang-version.yml CI Workflow.

@minikube-bot minikube-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 19, 2024
@spowelljr spowelljr changed the title Update go from 1.21.6 to Update go from 1.21.6 to 1.22.0 Feb 20, 2024
@spowelljr
Copy link
Member

/retest

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18197) |
+----------------+----------+---------------------+
| minikube start | 49.9s    | 51.2s               |
| enable ingress | 27.6s    | 26.9s               |
+----------------+----------+---------------------+

Times for minikube start: 46.7s 50.3s 49.5s 50.8s 52.2s
Times for minikube (PR 18197) start: 52.2s 51.6s 50.3s 50.8s 51.3s

Times for minikube ingress: 28.1s 27.1s 27.2s 28.2s 27.2s
Times for minikube (PR 18197) ingress: 27.2s 27.2s 25.2s 26.7s 28.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18197) |
+----------------+----------+---------------------+
| minikube start | 24.0s    | 24.8s               |
| enable ingress | 21.1s    | 21.0s               |
+----------------+----------+---------------------+

Times for minikube start: 23.0s 21.6s 25.0s 24.7s 25.4s
Times for minikube (PR 18197) start: 25.3s 25.3s 25.3s 25.6s 22.3s

Times for minikube ingress: 20.8s 21.9s 20.8s 20.9s 20.8s
Times for minikube (PR 18197) ingress: 20.3s 20.8s 21.9s 20.9s 20.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18197) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 22.9s               |
| enable ingress | 34.8s    | 31.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.4s 30.4s 48.4s 31.4s 32.4s
Times for minikube (PR 18197) ingress: 32.3s 31.4s 31.4s 31.3s 31.4s

Times for minikube start: 20.8s 21.1s 20.7s 21.0s 23.8s
Times for minikube (PR 18197) start: 21.4s 21.0s 24.2s 23.8s 24.2s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_docker_arm64 TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestKubernetesUpgrade (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
Docker_Linux TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 0.00 (chart)
Docker_Linux TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 0.00 (chart)
Docker_Linux TestKubernetesUpgrade (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
Hyperkit_macOS TestDownloadOnly/v1.16.0/json-events (gopogh) 0.00 (chart)
Hyperkit_macOS TestDownloadOnly/v1.16.0/kubectl (gopogh) 0.00 (chart)
Hyperkit_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 0.00 (chart)
Hyperkit_macOS TestDownloadOnly/v1.28.4/json-events (gopogh) 0.00 (chart)
Hyperkit_macOS TestDownloadOnly/v1.28.4/kubectl (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/Setup (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/serial/CacheCmd/cache/CacheDelete (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/serial/CacheCmd/cache/delete (gopogh) 0.00 (chart)
KVM_Linux_containerd TestKubernetesUpgrade (gopogh) 0.00 (chart)
Hyperkit_macOS TestAddons/Setup (gopogh) 1.61 (chart)
Docker_Windows TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 1.64 (chart)
Docker_Windows TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 1.64 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 1.64 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 4519827 into kubernetes:master Feb 21, 2024
22 of 38 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: minikube-bot, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants