-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix downloading the wrong kubeadm images for k8s versions after minikube release #17373
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/retest-this-please |
kvm2 driver with docker runtime
Times for minikube start: 55.7s 54.4s 52.7s 51.9s 53.9s Times for minikube ingress: 27.9s 28.3s 27.9s 29.8s 27.9s docker driver with docker runtime
Times for minikube (PR 17373) start: 25.2s 23.2s 23.1s 23.6s 23.7s Times for minikube ingress: 20.4s 21.9s 20.4s 20.9s 20.5s docker driver with containerd runtime
Times for minikube ingress: 30.9s 18.9s 47.4s 30.9s 31.4s Times for minikube (PR 17373) start: 25.1s 21.7s 24.8s 24.4s 24.4s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
Before:
After:
11 second speedup by not downloading the wrong images the first time. This speed increase is dependent on internet speed, slower internet speeds with see a bigger improvement.