Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mkdir for ~/.ssh directory. #16934

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

sethrylan
Copy link
Contributor

@sethrylan sethrylan commented Jul 21, 2023

Description

fixes #16933

What approach did you use?

I looked at how ssh-keygen creates the ~/.ssh directory if it doesn't exist, and tried to match that behavior.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 21, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sethrylan / name: Seth Rylan Gainey (2587f3f)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 21, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @sethrylan!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @sethrylan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 21, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 21, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 21, 2023
@sethrylan sethrylan marked this pull request as ready for review July 21, 2023 23:05
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2023
@medyagh
Copy link
Member

medyagh commented Aug 9, 2023

CC: @ComradeProgrammer

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16934) |
+----------------+----------+---------------------+
| minikube start | 55.5s    | 54.1s               |
| enable ingress | 29.0s    | 29.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.9s 28.3s 29.8s 28.8s 29.3s
Times for minikube (PR 16934) ingress: 30.9s 29.3s 28.8s 28.9s 27.3s

Times for minikube start: 53.3s 56.0s 55.7s 57.9s 54.6s
Times for minikube (PR 16934) start: 52.2s 56.1s 54.1s 53.4s 55.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16934) |
+----------------+----------+---------------------+
| minikube start | 26.3s    | 25.0s               |
| enable ingress | 21.1s    | 21.0s               |
+----------------+----------+---------------------+

Times for minikube start: 24.2s 25.6s 27.1s 27.5s 27.0s
Times for minikube (PR 16934) start: 23.7s 26.3s 26.7s 24.1s 24.1s

Times for minikube ingress: 20.5s 20.9s 21.0s 20.9s 22.0s
Times for minikube (PR 16934) ingress: 20.5s 21.0s 22.0s 20.5s 21.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16934) |
+----------------+----------+---------------------+
| minikube start | 23.8s    | 24.1s               |
| enable ingress | 34.2s    | 31.2s               |
+----------------+----------+---------------------+

Times for minikube start: 21.7s 23.9s 26.2s 25.4s 21.7s
Times for minikube (PR 16934) start: 23.5s 24.4s 22.0s 24.9s 25.5s

Times for minikube ingress: 31.9s 31.0s 46.0s 31.0s 30.9s
Times for minikube (PR 16934) ingress: 30.9s 31.0s 32.0s 31.0s 30.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestFunctional/parallel/ConfigCmd (gopogh) 0.00 (chart)
Hyperkit_macOS TestCertOptions (gopogh) 4.76 (chart)
Hyperkit_macOS TestNetworkPlugins/group/custom-flannel/Start (gopogh) 5.56 (chart)
Hyperkit_macOS TestMinikubeProfile (gopogh) 15.87 (chart)
Docker_Linux_crio_arm64 TestPause/serial/SecondStartNoReconfiguration (gopogh) 21.32 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 1c430a4 into kubernetes:master Aug 10, 2023
17 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethrylan, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-env errors if ~/.ssh doesn't exist
6 participants