qemu on maos :Auto unblock bootpd from firewall for socket_vmnet network driver #16714

spowelljr · 2023-06-15T00:08:09Z

Before:

$ minikube start --driver qemu
😄  minikube v1.30.1 on Darwin 13.4 (arm64)
✨  Using the qemu2 driver based on user configuration
🌐  Automatically selected the socket_vmnet network
👍  Starting control plane node minikube in cluster minikube
🔥  Creating qemu2 VM (CPUs=2, Memory=4000MB, Disk=20000MB) ...

❌  Exiting due to IF_BOOTPD_FIREWALL: ip not found: failed to get IP address: could not find an IP address for 9a:c3:18:28:ed:ed
💡  Suggestion: 

    Your firewall is likely blocking bootpd, to unblock it run:
    sudo /usr/libexec/ApplicationFirewall/socketfilterfw --add /usr/libexec/bootpd
    sudo /usr/libexec/ApplicationFirewall/socketfilterfw --unblock /usr/libexec/bootpd

╭───────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                           │
│    😿  If the above advice does not help, please let us know:                             │
│    👉  https://github.com/kubernetes/minikube/issues/new/choose                           │
│                                                                                           │
│    Please run `minikube logs --file=logs.txt` and attach logs.txt to the GitHub issue.    │
│                                                                                           │
╰───────────────────────────────────────────────────────────────────────────────────────────╯

After:

$ minikube start --driver qemu
😄  minikube v1.30.1 on Darwin 13.4 (arm64)
✨  Using the qemu2 driver based on user configuration
🌐  Automatically selected the socket_vmnet network
🔑  Your firewall is blocking bootpd which is required for socket_vmnet. The following commands will be executed to unblock bootpd:

    $ sudo /usr/libexec/ApplicationFirewall/socketfilterfw --add /usr/libexec/bootpd 
    $ sudo /usr/libexec/ApplicationFirewall/socketfilterfw --unblock /usr/libexec/bootpd 


Password: 
👍  Starting control plane node minikube in cluster minikube
🔥  Creating qemu2 VM (CPUs=2, Memory=4000MB, Disk=20000MB) ...
🐳  Preparing Kubernetes v1.27.2 on Docker 24.0.2 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
🌟  Enabled addons: storage-provisioner, default-storageclass
🔎  Verifying Kubernetes components...
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

medyagh · 2023-06-15T20:19:16Z

/ok-to-test

medyagh · 2023-06-15T20:20:40Z

cmd/minikube/cmd/start.go

+		if err := test.Run(); err != nil {
+			klog.Infof("%v may require a password: %v", c.Args, err)
+			if !viper.GetBool("interactive") {
+				klog.Warningf("%s requires a password, and --interactive=false", c.Args)


this should be an out. for the UI

minikube-pr-bot · 2023-06-15T21:21:28Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16714) |
+----------------+----------+---------------------+
| minikube start | 52.6s    | 51.0s               |
| enable ingress | 27.9s    | 28.1s               |
+----------------+----------+---------------------+

Times for minikube start: 49.5s 51.3s 56.6s 54.7s 51.1s
Times for minikube (PR 16714) start: 50.9s 49.4s 52.9s 50.6s 51.2s

Times for minikube ingress: 28.2s 29.7s 27.8s 26.7s 27.3s
Times for minikube (PR 16714) ingress: 27.2s 28.6s 28.3s 28.2s 28.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16714) |
+----------------+----------+---------------------+
| minikube start | 23.8s    | 23.8s               |
| enable ingress | 48.8s    | 49.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 48.3s 49.3s 48.9s 49.3s 48.3s
Times for minikube (PR 16714) ingress: 49.8s 49.3s 48.4s 49.3s 48.9s

Times for minikube start: 22.2s 25.2s 25.0s 21.8s 24.9s
Times for minikube (PR 16714) start: 24.2s 24.4s 22.1s 24.2s 24.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16714) |
+----------------+----------+---------------------+
| minikube start | 23.7s    | 22.1s               |
| enable ingress | 30.9s    | 30.9s               |
+----------------+----------+---------------------+

Times for minikube start: 22.9s 24.0s 23.8s 24.0s 24.0s
Times for minikube (PR 16714) start: 22.5s 22.3s 20.3s 21.1s 24.6s

Times for minikube ingress: 31.3s 31.3s 31.3s 30.4s 30.3s
Times for minikube (PR 16714) ingress: 31.3s 31.3s 31.3s 30.3s 30.3s

minikube-pr-bot · 2023-06-15T23:27:01Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Hyper-V_Windows	TestStartStop/group/newest-cni/serial/Pause (gopogh)	0.00 (chart)
Hyper-V_Windows	TestStartStop/group/newest-cni/serial/SecondStart (gopogh)	0.00 (chart)
Hyper-V_Windows	TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh)	0.00 (chart)
Hyper-V_Windows	TestPause/serial/SecondStartNoReconfiguration (gopogh)	11.11 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	45.68 (chart)

To see the flake rates of all tests by environment, click here.

medyagh

do u mind sharing the output Second time after run ? we should expect on the second time, it should not yell at the user or unenescarily run the sudo commands anymore (since been added already)

k8s-ci-robot · 2023-06-22T17:28:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

socket_vmnet: Auto unblock bootpd from firewall

29a3258

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 15, 2023

k8s-ci-robot requested review from afbjorklund and sharifelgamal June 15, 2023 00:08

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 15, 2023

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 15, 2023

medyagh requested changes Jun 15, 2023

View reviewed changes

medyagh changed the title ~~socket_vmnet: Auto unblock bootpd from firewall~~ qemu on maos :Auto unblock bootpd from firewall for socket_vmnet network driver Jun 15, 2023

medyagh requested changes Jun 15, 2023

View reviewed changes

medyagh approved these changes Jun 22, 2023

View reviewed changes

medyagh merged commit a209cfb into kubernetes:master Jun 22, 2023

spowelljr deleted the unblock branch June 28, 2023 20:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qemu on maos :Auto unblock bootpd from firewall for socket_vmnet network driver #16714

qemu on maos :Auto unblock bootpd from firewall for socket_vmnet network driver #16714

spowelljr commented Jun 15, 2023 •

edited

Loading

medyagh commented Jun 15, 2023

medyagh Jun 15, 2023

minikube-pr-bot commented Jun 15, 2023

minikube-pr-bot commented Jun 15, 2023

medyagh left a comment

k8s-ci-robot commented Jun 22, 2023

qemu on maos :Auto unblock bootpd from firewall for socket_vmnet network driver #16714

qemu on maos :Auto unblock bootpd from firewall for socket_vmnet network driver #16714

Conversation

spowelljr commented Jun 15, 2023 • edited Loading

medyagh commented Jun 15, 2023

medyagh Jun 15, 2023

Choose a reason for hiding this comment

minikube-pr-bot commented Jun 15, 2023

minikube-pr-bot commented Jun 15, 2023

medyagh left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jun 22, 2023

spowelljr commented Jun 15, 2023 •

edited

Loading