Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only wait for KIC base image when using KIC driver #16420

Merged
merged 1 commit into from
May 8, 2023

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented May 2, 2023

Fixes #16421

Prevent outputting message about downloading kic artifacts if not using kic driver

Before:

$ minikube start --driver qemu --download-only --alsologtostderr
...
I0502 15:19:50.838287   54902 binary.go:76] Not caching binary, using https://dl.k8s.io/release/v1.26.3/bin/darwin/arm64/kubectl?checksum=file:https://dl.k8s.io/release/v1.26.3/bin/darwin/arm64/kubectl.sha256
I0502 15:19:50.838298   54902 cache.go:193] Successfully downloaded all kic artifacts
I0502 15:19:50.842395   54902 out.go:177] ✅  Download complete!

After:

$ minikube start --driver qemu --download-only --alsologtostderr
...
I0502 15:22:17.692883   55316 binary.go:76] Not caching binary, using https://dl.k8s.io/release/v1.26.3/bin/darwin/arm64/kubectl?checksum=file:https://dl.k8s.io/release/v1.26.3/bin/darwin/arm64/kubectl.sha256
I0502 15:22:17.697828   55316 out.go:177] ✅  Download complete!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2023
@k8s-ci-robot k8s-ci-robot requested review from afbjorklund and prezha May 2, 2023 22:26
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2023
@medyagh medyagh merged commit 95acadc into kubernetes:master May 8, 2023
@spowelljr spowelljr deleted the skipKICWait branch May 8, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Successfully downloaded all kic artifacts when not using KIC driver
3 participants