Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn users if using VirtualBox on macOS 13+ #15624

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Warn users if using VirtualBox on macOS 13+ #15624

merged 2 commits into from
Jan 24, 2023
+45 −0

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Jan 10, 2023 •
edited
Loading

Related #15274

$ minikube start --driver virtualbox
😄  minikube v1.28.0 on Darwin 13.1 (arm64)
✨  Using the virtualbox driver based on user configuration
❗  Due to changes in macOS 13+ minikube doesn't currently support VirtualBox. You can use alternative drivers such as docker or qemu.
    https://minikube.sigs.k8s.io/docs/drivers/docker/
    https://minikube.sigs.k8s.io/docs/drivers/qemu/

    For more details on the issue see: https://github.com/kubernetes/minikube/issues/15274

👍  Starting control plane node minikube in cluster minikube
...

If the user tries using the VirtualBox driver on macOS 13+ the warning above is output.

If the machine is amd64 it will recommend the hyperkit driver, if arm64 it will recommend the qemu driver.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 10, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2023
medyagh
medyagh requested changes Jan 11, 2023
View reviewed changes
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2023
@spowelljr spowelljr merged commit 10c9ba2 into kubernetes:master Jan 24, 2023
@spowelljr spowelljr deleted the warnVirtualBoxMacOS branch January 24, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spowelljr @k8s-ci-robot @medyagh