fix qemu firmware path locations #14182
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
kvm2 driver with docker runtime Times for minikube start: 52.0s 53.2s 51.0s 51.9s 51.9s Times for minikube ingress: 30.1s 30.2s 30.1s 27.2s 29.1s docker driver with docker runtime Times for minikube start: 26.6s 24.8s 24.8s 25.2s 25.3s Times for minikube ingress: 21.4s 21.5s 21.9s 82.9s 21.9s docker driver with containerd runtime Times for minikube start: 34.1s 44.4s 40.0s 41.1s 45.6s Times for minikube ingress: 19.0s 18.0s 22.0s 22.4s 18.0s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
There was a problem hiding this comment.
// kvm acceleration doesn't currently work for linux, it's incompatible with our chosen CPU
Weird about the KVM, I think it was supposed to use "host" as the cpu
Also had to set "gic-version" (for the real ARM host), whatever that is.
if [ -e /dev/kvm -a "`arch`" = "x86_64" ]; then
options="-enable-kvm"
else
options=""
fi
if [ -e /dev/kvm -a "`arch`" = "aarch64" ]; then
options="-enable-kvm -cpu host -machine gic-version=3"
else
options="-cpu cortex-a53"
fiUsing -accel kvm instead makes it more similar to the other platforms.
Adding |
|
kvm2 driver with docker runtime Times for minikube ingress: 29.0s 26.6s 30.1s 29.6s 26.6s Times for minikube start: 53.3s 50.9s 50.4s 54.9s 51.1s docker driver with docker runtime Times for minikube start: 30.8s 25.0s 24.7s 24.8s 24.7s Times for minikube ingress: 22.9s 22.5s 21.9s 21.9s 21.4s docker driver with containerd runtime Times for minikube start: 34.2s 40.8s 29.9s 28.3s 44.7s Times for minikube (PR 14182) ingress: 52.4s 18.9s 22.4s 19.9s 18.9s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, klaases, sharifelgamal, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
kvm2 driver with docker runtime Times for minikube start: 53.5s 50.2s 50.6s 50.5s 49.9s Times for minikube ingress: 28.6s 28.5s 30.0s 25.5s 27.0s docker driver with docker runtime Times for minikube start: 26.5s 24.4s 24.6s 24.3s 25.3s Times for minikube (PR 14182) ingress: 25.9s 20.9s 22.9s 20.9s 22.9s docker driver with containerd runtime Times for minikube ingress: 22.4s 23.4s 32.5s 22.4s 18.9s Times for minikube start: 29.6s 28.5s 28.2s 28.7s 31.6s |
|
kvm2 driver with docker runtime Times for minikube (PR 14182) start: 52.3s 51.9s 51.2s 50.9s 52.0s Times for minikube ingress: 29.1s 30.1s 29.1s 29.1s 29.6s docker driver with docker runtime Times for minikube (PR 14182) start: 24.9s 25.7s 24.2s 25.3s 25.3s Times for minikube ingress: 26.5s 82.9s 23.0s 24.0s 21.9s docker driver with containerd runtime Times for minikube (PR 14182) start: 29.6s 29.0s 32.5s 32.7s 29.3s Times for minikube ingress: 18.9s 22.4s 18.0s 22.5s 17.9s |
|
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
|
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
This PR figures out the location of the qemu firmware path dynamically, rather than hardcoding a version path. Note that this still requires qemu to be installed by homebrew.
This also allows x86_64 macOS machines to take advantage of hvf hardware acceleration for the qemu2 driver.
Fixes #14176