Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rootless Podman driver, take 2 (Usage: minikube config set rootless true) #13829

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Mar 22, 2022

Usage:

minikube config set rootless true
minikube start --driver=podman --container-runtime=cri-o

The container runtime can be set to containerd too.

Tested on Podman 4.0.2, Ubuntu 21.10.

Needs cgroup v2 (as in Rootless Docker): https://rootlesscontaine.rs/getting-started/common/cgroup2/
See also site/content/en/docs/drivers/includes/podman_usage.inc

Fixes #8719
Fixes #12460
Replaces PR #12901

Changes from PR #12901 (take 1): rootless is now a config property.
In the previous PR, --rootless was implemented as a flag for minikube start

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 22, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh
Copy link
Member

medyagh commented Mar 22, 2022

thank you @AkihiroSuda for this PR, I see there is another PR #13828

do you mind clarifying their relations ? does one of them depend on the other one ?

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Mar 23, 2022

thank you @AkihiroSuda for this PR, I see there is another PR #13828

do you mind clarifying their relations ? does one of them depend on the other one ?

Orthogonal.
#13828 is a bug fix for --container-runtime=containerd that has been broken since minikube 1.25.
#13829 is for adding a support for --driver=podman --rootless --container-runtime=(crio|containerd).
#13829 does not depend on #13828 (unless used in conjunction with --container-runtime=containerd)

@medyagh
Copy link
Member

medyagh commented Mar 23, 2022

thank you @AkihiroSuda for this PR, I see there is another PR #13828
do you mind clarifying their relations ? does one of them depend on the other one ?

Orthogonal. #13828 is a bug fix for --container-runtime=containerd that has been broken since minikube 1.25. #13829 is for adding a support for --driver=podman --rootless --container-runtime=(crio|containerd). #13829 does not depend on #13828 (unless used in conjunction with --container-runtime=containerd)

thank you very much for clarifying

@medyagh
Copy link
Member

medyagh commented Mar 23, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 23, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13829) |
+----------------+----------+---------------------+
| minikube start | 53.0s    | 52.2s               |
| enable ingress | 29.2s    | 28.5s               |
+----------------+----------+---------------------+

Times for minikube start: 53.7s 53.5s 53.4s 51.7s 52.7s
Times for minikube (PR 13829) start: 52.5s 52.5s 51.6s 52.7s 51.9s

Times for minikube ingress: 30.5s 30.6s 29.1s 29.0s 26.6s
Times for minikube (PR 13829) ingress: 29.5s 30.0s 29.0s 28.5s 25.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13829) |
+----------------+----------+---------------------+
| minikube start | 25.8s    | 26.0s               |
| enable ingress | 22.2s    | 22.9s               |
+----------------+----------+---------------------+

Times for minikube start: 25.2s 25.7s 26.1s 25.8s 25.9s
Times for minikube (PR 13829) start: 26.6s 26.2s 25.6s 25.8s 26.0s

Times for minikube (PR 13829) ingress: 22.4s 22.9s 25.9s 21.9s 21.4s
Times for minikube ingress: 20.4s 22.4s 23.4s 22.9s 21.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13829) |
+----------------+----------+---------------------+
| minikube start | 43.0s    | 41.7s               |
| enable ingress | 24.8s    | 21.5s               |
+----------------+----------+---------------------+

Times for minikube start: 41.7s 45.9s 41.0s 40.7s 45.9s
Times for minikube (PR 13829) start: 40.7s 40.2s 42.7s 40.2s 44.4s

Times for minikube ingress: 23.4s 17.9s 32.4s 22.4s 27.9s
Times for minikube (PR 13829) ingress: 22.4s 22.4s 22.4s 22.4s 17.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/embed-certs/serial/Pause (gopogh) 5.92 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 18.56 (chart)
Docker_Linux_containerd TestAddons/Setup (gopogh) 21.56 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 21.56 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 21.56 (chart)
Docker_Linux_containerd TestJSONOutput/start/Audit (gopogh) 21.56 (chart)
Docker_Linux_containerd TestJSONOutput/start/Command (gopogh) 21.56 (chart)
Docker_Linux_containerd TestMultiNode/serial/AddNode (gopogh) 21.56 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeleteNode (gopogh) 21.56 (chart)
Docker_Linux_containerd TestMultiNode/serial/FreshStart2Nodes (gopogh) 21.56 (chart)
Docker_Linux_containerd TestMultiNode/serial/ProfileList (gopogh) 21.56 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartKeepsNodes (gopogh) 21.56 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartMultiNode (gopogh) 21.56 (chart)
Docker_Linux_containerd TestMultiNode/serial/StartAfterStop (gopogh) 21.56 (chart)
Docker_Linux_containerd TestMultiNode/serial/StopNode (gopogh) 21.56 (chart)
Docker_Linux_containerd TestPreload (gopogh) 21.56 (chart)
Docker_Linux_containerd TestOffline (gopogh) 28.74 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmdConnect (gopogh) 30.32 (chart)
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 31.14 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 31.14 (chart)
Docker_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 31.14 (chart)
Docker_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 31.14 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 31.14 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 31.14 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 31.14 (chart)
Docker_Linux_containerd TestFunctional/serial/ExtraConfig (gopogh) 31.14 (chart)
Docker_Linux_containerd TestFunctional/serial/SoftStart (gopogh) 31.14 (chart)
Docker_Linux_containerd TestFunctional/serial/StartWithProxy (gopogh) 31.14 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeployApp2Nodes (gopogh) 31.14 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@jesperpedersen
Copy link

@AkihiroSuda What do you think about adding rootless to cmd/minikube/cmd/config/config.go ? That way you can do

minikube config set rootless true

Looking forward to this feature !

@AkihiroSuda
Copy link
Member Author

@AkihiroSuda What do you think about adding rootless to cmd/minikube/cmd/config/config.go ? That way you can do

minikube config set rootless true

Looking forward to this feature !

Thanks for the suggestion 👍 , updated PR to support minikube config set rootless true.

@AkihiroSuda AkihiroSuda changed the title Support rootless Podman driver, take 2 Support rootless Podman driver, take 2 (Usage: minikube config set rootless true) Mar 26, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13829) |
+----------------+----------+---------------------+
| minikube start | 52.9s    | 52.3s               |
| enable ingress | 27.5s    | 28.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 13829) start: 52.2s 51.7s 52.0s 53.1s 52.4s
Times for minikube start: 54.1s 51.7s 52.6s 53.5s 52.4s

Times for minikube ingress: 30.1s 27.0s 25.6s 29.1s 26.0s
Times for minikube (PR 13829) ingress: 28.5s 28.1s 27.5s 29.0s 29.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13829) |
+----------------+----------+---------------------+
| minikube start | 26.3s    | 25.9s               |
| enable ingress | 24.5s    | 23.0s               |
+----------------+----------+---------------------+

Times for minikube start: 26.2s 27.1s 27.0s 25.7s 25.4s
Times for minikube (PR 13829) start: 27.2s 25.7s 25.6s 25.6s 25.5s

Times for minikube ingress: 22.9s 22.9s 26.9s 25.4s 24.4s
Times for minikube (PR 13829) ingress: 25.9s 21.9s 22.4s 21.9s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13829) |
+----------------+----------+---------------------+
| minikube start | 41.2s    | 43.3s               |
| enable ingress | 21.6s    | 19.9s               |
+----------------+----------+---------------------+

Times for minikube start: 29.8s 45.0s 45.1s 45.0s 41.3s
Times for minikube (PR 13829) start: 44.9s 44.8s 40.8s 45.6s 40.5s

Times for minikube ingress: 22.4s 17.9s 27.9s 17.9s 21.9s
Times for minikube (PR 13829) ingress: 17.9s 18.9s 22.4s 17.9s 22.4s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13829) |
+----------------+----------+---------------------+
| minikube start | 53.5s    | 52.9s               |
| enable ingress | 29.0s    | 27.2s               |
+----------------+----------+---------------------+

Times for minikube start: 53.9s 52.7s 55.4s 52.2s 53.3s
Times for minikube (PR 13829) start: 52.8s 55.9s 52.2s 52.1s 51.3s

Times for minikube ingress: 29.0s 28.5s 29.6s 29.1s 29.0s
Times for minikube (PR 13829) ingress: 29.1s 25.5s 26.0s 29.5s 25.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13829) |
+----------------+----------+---------------------+
| minikube start | 25.9s    | 25.6s               |
| enable ingress | 23.1s    | 23.2s               |
+----------------+----------+---------------------+

Times for minikube start: 27.0s 26.1s 26.4s 24.9s 25.3s
Times for minikube (PR 13829) start: 25.2s 26.0s 25.7s 25.9s 24.9s

Times for minikube ingress: 25.9s 21.9s 22.9s 22.0s 22.9s
Times for minikube (PR 13829) ingress: 21.9s 21.4s 23.0s 26.9s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13829) |
+----------------+----------+---------------------+
| minikube start | 41.3s    | 43.0s               |
| enable ingress | 22.1s    | 20.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.9s 22.4s 22.4s 18.9s 17.9s
Times for minikube (PR 13829) ingress: 22.4s 17.9s 17.9s 22.0s 21.9s

Times for minikube start: 34.5s 40.8s 41.0s 44.0s 46.1s
Times for minikube (PR 13829) start: 40.5s 46.0s 46.0s 41.2s 41.5s

@jesperpedersen
Copy link

Thanks for the suggestion +1 , updated PR to support minikube config set rootless true.

Works - podman 3.4.4 w/ CRI-O 1.22.3 (Fedora 35) ! Thank you 👍

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestNetworkPlugins/group/enable-default-cni/NetCatPod (gopogh) 1.71 (chart)
Docker_Linux_containerd TestKubernetesUpgrade (gopogh) 3.61 (chart)
Docker_Linux TestStartStop/group/embed-certs/serial/Pause (gopogh) 6.88 (chart)
Docker_Linux TestNetworkPlugins/group/auto/DNS (gopogh) 7.50 (chart)
Docker_macOS TestNetworkPlugins/group/false/DNS (gopogh) 19.47 (chart)
Hyper-V_Windows TestNetworkPlugins/group/flannel/Start (gopogh) 20.42 (chart)
Docker_Windows TestNoKubernetes/serial/Stop (gopogh) 24.00 (chart)
Hyper-V_Windows TestSkaffold (gopogh) 26.06 (chart)
Docker_Windows TestSkaffold (gopogh) 26.98 (chart)
Hyper-V_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 33.10 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 35.62 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 38.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 38.03 (chart)
Docker_Linux TestFunctional/serial/ComponentHealth (gopogh) 41.88 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 43.53 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/DNS (gopogh) 47.95 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 48.24 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 49.00 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/Start (gopogh) 50.00 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 50.33 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 50.33 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/DNS (gopogh) 54.08 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 58.87 (chart)
Docker_Linux TestNetworkPlugins/group/custom-weave/Start (gopogh) 60.00 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 60.28 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/DNS (gopogh) 61.39 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 64.29 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 66.67 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 70.00 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 71.25 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestNetworkPlugins/group/auto/DNS (gopogh) 2.63 (chart)
Docker_Linux_containerd TestFunctional/serial/LogsFileCmd (gopogh) 7.19 (chart)
Docker_macOS TestDownloadOnlyKic (gopogh) 7.79 (chart)
Docker_macOS TestDownloadOnly/v1.23.3/preload-exists (gopogh) 7.79 (chart)
Docker_macOS TestNetworkPlugins/group/false/DNS (gopogh) 19.30 (chart)
Docker_Windows TestPause/serial/Pause (gopogh) 21.05 (chart)
Docker_Windows TestKubernetesUpgrade (gopogh) 26.98 (chart)
Docker_Windows TestSkaffold (gopogh) 26.98 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 28.17 (chart)
Docker_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 29.27 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/DNS (gopogh) 29.82 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 32.61 (chart)
Docker_macOS TestNetworkPlugins/group/calico/DNS (gopogh) 34.55 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/Start (gopogh) 47.89 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 50.65 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 50.65 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 63.72 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 71.43 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) 100.00 (chart)
Docker_Windows TestNetworkPlugins/group/cilium/Start (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

Usage:
```
minikube config set rootless true
minikube start --driver=podman --container-runtime=(cri-o|containerd)`
```

Tested on Podman 4.0.2, Ubuntu 21.10.

Needs cgroup v2 (as in Rootless Docker): https://rootlesscontaine.rs/getting-started/common/cgroup2/
See also `site/content/en/docs/drivers/includes/podman_usage.inc`

Fix issue 8719
Fix issue 12460
Replace PR 12901

Changes from PR 12901: `rootless` is now a config property.
In the previous PR, `--rootless` was implemented as a flag for `minikube start`

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
Copy link
Member Author

Rebased

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13829) |
+----------------+----------+---------------------+
| minikube start | 63.4s    | 63.1s               |
| enable ingress | 29.7s    | 28.0s               |
+----------------+----------+---------------------+

Times for minikube start: 63.9s 63.6s 63.6s 62.8s 63.2s
Times for minikube (PR 13829) start: 62.0s 62.8s 63.5s 63.1s 64.0s

Times for minikube ingress: 28.5s 30.0s 29.0s 31.0s 30.0s
Times for minikube (PR 13829) ingress: 29.0s 29.0s 29.5s 26.0s 26.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13829) |
+----------------+----------+---------------------+
| minikube start | 36.0s    | 36.1s               |
| enable ingress | 22.5s    | 22.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.9s 20.9s 22.9s 21.9s 23.9s
Times for minikube (PR 13829) ingress: 22.9s 21.4s 22.4s 22.4s 23.0s

Times for minikube start: 37.1s 35.4s 36.0s 35.7s 35.8s
Times for minikube (PR 13829) start: 35.9s 36.0s 36.7s 36.0s 36.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13829) |
+----------------+----------+---------------------+
| minikube start | 57.5s    | 59.3s               |
| enable ingress | 26.9s    | 29.5s               |
+----------------+----------+---------------------+

Times for minikube start: 51.0s 59.4s 58.9s 58.7s 59.3s
Times for minikube (PR 13829) start: 58.8s 58.6s 59.4s 60.9s 58.7s

Times for minikube ingress: 31.0s 30.9s 31.1s 20.8s 20.9s
Times for minikube (PR 13829) ingress: 21.0s 25.0s 51.9s 28.9s 20.8s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestCertExpiration (gopogh) 0.65 (chart)
Docker_macOS TestSkaffold (gopogh) 1.96 (chart)
Docker_Linux TestNoKubernetes/serial/Start (gopogh) 3.25 (chart)
KVM_Linux TestErrorSpam/setup (gopogh) 4.65 (chart)
KVM_Linux_containerd TestErrorSpam/setup (gopogh) 4.68 (chart)
Hyperkit_macOS TestErrorSpam/setup (gopogh) 6.17 (chart)
Hyper-V_Windows TestNetworkPlugins/group/calico/Start (gopogh) 7.19 (chart)
Hyper-V_Windows TestNetworkPlugins/group/cilium/Start (gopogh) 7.19 (chart)
Hyper-V_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 9.35 (chart)
Hyper-V_Windows TestNetworkPlugins/group/false/Start (gopogh) 11.51 (chart)
Hyper-V_Windows TestErrorSpam/setup (gopogh) 14.39 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/AddonExistsAfterStop (gopogh) 17.31 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/EnableAddonAfterStop (gopogh) 17.83 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/Stop (gopogh) 17.83 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/UserAppExistsAfterStop (gopogh) 18.35 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/SecondStart (gopogh) 18.87 (chart)
Hyper-V_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 23.02 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 26.19 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 26.19 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 26.77 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 26.77 (chart)
Hyper-V_Windows TestNetworkPlugins/group/flannel/Start (gopogh) 27.34 (chart)
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 28.48 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/DeployApp (gopogh) 28.57 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/FirstStart (gopogh) 29.13 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/SecondStart (gopogh) 30.16 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 30.71 (chart)
Docker_macOS TestStartStop/group/newest-cni/serial/FirstStart (gopogh) 31.82 (chart)
Hyper-V_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 37.41 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 42.45 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@AkihiroSuda
Copy link
Member Author

@medyagh @afbjorklund Could you take a look? 🙏

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2022
@sharifelgamal sharifelgamal merged commit ad5c964 into kubernetes:master Apr 12, 2022
@jesperpedersen
Copy link

🍾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hardcoded sudo from commands and make it conditional rootless podman driver
7 participants