-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support rootless Podman driver, take 2 (Usage: minikube config set rootless true
)
#13829
Support rootless Podman driver, take 2 (Usage: minikube config set rootless true
)
#13829
Conversation
Can one of the admins verify this patch? |
825ca17
to
9b32356
Compare
thank you @AkihiroSuda for this PR, I see there is another PR #13828 do you mind clarifying their relations ? does one of them depend on the other one ? |
Orthogonal. |
thank you very much for clarifying |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 53.7s 53.5s 53.4s 51.7s 52.7s Times for minikube ingress: 30.5s 30.6s 29.1s 29.0s 26.6s docker driver with docker runtime
Times for minikube start: 25.2s 25.7s 26.1s 25.8s 25.9s Times for minikube (PR 13829) ingress: 22.4s 22.9s 25.9s 21.9s 21.4s docker driver with containerd runtime
Times for minikube start: 41.7s 45.9s 41.0s 40.7s 45.9s Times for minikube ingress: 23.4s 17.9s 32.4s 22.4s 27.9s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
@AkihiroSuda What do you think about adding
Looking forward to this feature ! |
9b32356
to
c9db704
Compare
Thanks for the suggestion 👍 , updated PR to support |
minikube config set rootless true
)
c9db704
to
38593d1
Compare
kvm2 driver with docker runtime
Times for minikube (PR 13829) start: 52.2s 51.7s 52.0s 53.1s 52.4s Times for minikube ingress: 30.1s 27.0s 25.6s 29.1s 26.0s docker driver with docker runtime
Times for minikube start: 26.2s 27.1s 27.0s 25.7s 25.4s Times for minikube ingress: 22.9s 22.9s 26.9s 25.4s 24.4s docker driver with containerd runtime
Times for minikube start: 29.8s 45.0s 45.1s 45.0s 41.3s Times for minikube ingress: 22.4s 17.9s 27.9s 17.9s 21.9s |
kvm2 driver with docker runtime
Times for minikube start: 53.9s 52.7s 55.4s 52.2s 53.3s Times for minikube ingress: 29.0s 28.5s 29.6s 29.1s 29.0s docker driver with docker runtime
Times for minikube start: 27.0s 26.1s 26.4s 24.9s 25.3s Times for minikube ingress: 25.9s 21.9s 22.9s 22.0s 22.9s docker driver with containerd runtime
Times for minikube ingress: 28.9s 22.4s 22.4s 18.9s 17.9s Times for minikube start: 34.5s 40.8s 41.0s 44.0s 46.1s |
Works - podman 3.4.4 w/ CRI-O 1.22.3 (Fedora 35) ! Thank you 👍 |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
Usage: ``` minikube config set rootless true minikube start --driver=podman --container-runtime=(cri-o|containerd)` ``` Tested on Podman 4.0.2, Ubuntu 21.10. Needs cgroup v2 (as in Rootless Docker): https://rootlesscontaine.rs/getting-started/common/cgroup2/ See also `site/content/en/docs/drivers/includes/podman_usage.inc` Fix issue 8719 Fix issue 12460 Replace PR 12901 Changes from PR 12901: `rootless` is now a config property. In the previous PR, `--rootless` was implemented as a flag for `minikube start` Signed-off-by: Akihiro Suda <[email protected]>
Rebased |
38593d1
to
92ab555
Compare
kvm2 driver with docker runtime
Times for minikube start: 63.9s 63.6s 63.6s 62.8s 63.2s Times for minikube ingress: 28.5s 30.0s 29.0s 31.0s 30.0s docker driver with docker runtime
Times for minikube ingress: 22.9s 20.9s 22.9s 21.9s 23.9s Times for minikube start: 37.1s 35.4s 36.0s 35.7s 35.8s docker driver with containerd runtime
Times for minikube start: 51.0s 59.4s 58.9s 58.7s 59.3s Times for minikube ingress: 31.0s 30.9s 31.1s 20.8s 20.9s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
@medyagh @afbjorklund Could you take a look? 🙏 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AkihiroSuda, sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🍾 |
Usage:
The container runtime can be set to
containerd
too.Tested on Podman 4.0.2, Ubuntu 21.10.
Needs cgroup v2 (as in Rootless Docker): https://rootlesscontaine.rs/getting-started/common/cgroup2/
See also
site/content/en/docs/drivers/includes/podman_usage.inc
Fixes #8719
Fixes #12460
Replaces PR #12901
Changes from PR #12901 (take 1):
rootless
is now a config property.In the previous PR,
--rootless
was implemented as a flag forminikube start